Skip to content

Fixed uncatched exception in data stream #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daerup wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed uncatched exception in data stream #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/ipcInterface/ipcInterface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,13 @@ ipcInterface.prototype = Object.assign({
this.socket.on('error', (error) => this.errHandler(error));

// Parse the data received from the socket and handle it to the mpv module
this.socket.on('data', (data) => this.dataHandler(data));
this.socket.on('data', (data) => {
try {
this.dataHandler(data)
} catch (error) {
this.errHandler(error)
}
});

// partially 'fixes' the EventEmitter leak
// the leaking listeners is 'close', but I did not yet find any solution to fix it
Expand Down