Add go to line dialog.

[ikolokolnikov]

The user is now able to go to any particular line by entering a line number
into "Go to Line" dialog instead of manually scrolling.

[j6t]

Thank you for this contribution. In general, I like it.

Regarding behavior:

• I would prefer that the edit box has the focus and all text selected after pressing Ctrl-G, so that I can start typing a new line number without having to delete an existing line number. This is already the case if the dialog was closed with Enter or Esc before, but is not the case when a button was clicked. But this should be a commit on top.
• I expanded some assembly lines, then selected to go to one past the last line. This locks up the UI (infinite loop).

Regarding the implementation:

• There is a KStandardAction::gotoLine that we could use. It is desirable to use the modern slot overload taking a member function pointer rather than the SLOT(...) macro, if possible, despite the surrounding code doing it differently.
• There is QIntValidator that we could use. If it's not possible, please justify it.
• Please keep #include files sorted within their category as far as possible.

In your clone of this repository, kindly set your user.name to your full name.

[ikolokolnikov]

Ok, I think I fixed everything.

[j6t]

Thanks, this is already looking very good.

One nit, though: I wonder why we need actionCollection()->addAction(...) here, but not in other cases, and I think it is because you want a custom name for the action. However, if you use the standard name, go_goto_line, we can avoid it. It does not matter that this ID is listed in the View menu, I think.

[ikolokolnikov]

I tried that before, but it seems that it ignores the entry go_goto_line entry in the kdbgui.rc file and still places the action into "Go" menu. I am not sure if I misunderstand something.

Update: After removing a cached .rc file, I managed to put go_goto_line into the View menu, however it still adds the Go menu with a duplicate "Go to Line..." action.

Update 2: I managed to remove the duplicate menu by doing:

  <Menu name="go" deleted="true">
  </Menu>

I am just not sure that this would be an acceptable approach.

[j6t]

I see. That's too ugly. Let's use the addAction call with the custom name, but add a comment that explains why we do this.

[ikolokolnikov]

Done.

[j6t]

Thanks!