Refactor CI workflows and devcontainer configuration for improved cla… - #2
Merged
Conversation
…rity and flexibility
…roved performance and security
…vcontainer changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the development and CI environment configuration to improve flexibility and consistency, especially regarding ROS distribution selection. The changes primarily focus on parameterizing the ROS distribution in workflows and devcontainer settings, making it easier to switch between different ROS versions (like "humble" or "iron") without modifying multiple hardcoded values. It also cleans up and modernizes some workflow files.
Key changes include:
Parameterization and Environment Consistency
ROS_DISTROenvironment variable in both.github/workflows/build-docker.ymland.github/workflows/copilot-setup-steps.yml, allowing easier switching between ROS versions. [1] [2] [3] [4]${ROS_DISTRO}instead of fixed values, ensuring consistency across all scripts and jobs. [1] [2]Devcontainer and Workflow Improvements
.devcontainer/devcontainer.jsonfor broader applicability..github/workflows/dev-container.ymlto trigger on changes to devcontainer-related files, not just on pushes to the main branch, improving CI relevance.Metadata and Workflow Cleanup
.github/workflows/build-docker.yml.actions/checkoutaction from v3 to v6 in.github/workflows/ros-ci.ymlfor improved security and features..github/workflows/ros-ci.yml, simplifying the workflow. [1] [2] [3]