Skip to content

fix: acknowledge precision recommendation refresh #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackhai9 merged 1 commit into from
Aug 27, 2026
Merged

fix: acknowledge precision recommendation refresh #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion e2e/binance-orderbook/specs/control-flows.pw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,16 @@ test('precision refresh uses the visible latest trades immediately without a sam
await installInteractionProbe(page, '[data-orderbook-precision-refresh]');
await refresh.click();
await expect(refresh).toBeEnabled();
await expect(refresh).toHaveAttribute('data-orderbook-precision-refresh-state', 'success');
await expect(refresh).toHaveAttribute('aria-label', '精度推荐已更新');
await expect(panel.locator('[data-orderbook-precision-value="0.01"]'))
.toHaveAttribute('aria-label', '切换价格精度到 0.01，推荐档位');
const probe = await finishInteractionProbe(page);
assertResponsiveInteraction(expect, probe);
expect(await page.evaluate((symbol) => JSON.parse(
localStorage.getItem(`jh_binance_orderbook_precision_samples_v3:${symbol}`)
), scenario.currentSymbol)).toEqual(['0.01', '0.01', '0.01', '0.01', '0.01']);
await expect(refresh).toHaveAttribute('data-orderbook-precision-refresh-state', 'idle', { timeout: 2_000 });
expect(errors).toEqual([]);
});

Expand All @@ -123,7 +126,10 @@ test('precision refresh explains when the complete visible trade list still lack
nodes.forEach((node) => { node.textContent = '81.00'; });
});

await panel.locator('[data-orderbook-precision-refresh]').click();
const refresh = panel.locator('[data-orderbook-precision-refresh]');
await refresh.click();
await expect(refresh).toHaveAttribute('data-orderbook-precision-refresh-state', 'retry');
await expect(refresh).toHaveAttribute('aria-label', '近期价格变化不足，请稍后重试');
await expect(panel.locator('#jh-binance-ladder-status'))
.toHaveText('近期价格变化不足，请稍后重试');
await expect(panel.locator('[aria-label*="推荐档位"]')).toHaveCount(0);
Expand Down
43 changes: 40 additions & 3 deletions scripts/binance-orderbook-trade.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// @namespace binance.orderbook.trade
// @icon data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @icon64 data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @version 2.7.127
// @version 2.7.128
// @author jackhai9
// @description 单击订单簿价格，按当前开仓/平仓 tab 自动填数量并执行下单，内置数量倍率面板
// @match https://www.binance.com/*/futures/*
Expand Down Expand Up @@ -1853,6 +1853,7 @@
const ORDERBOOK_PRECISION_TRADE_EXPANSION_STEP = 10;
const ORDERBOOK_PRECISION_MIN_EFFECTIVE_MOVES = 5;
const ORDERBOOK_PRECISION_SHORTCUT_LIMIT = 4;
const ORDERBOOK_PRECISION_REFRESH_FEEDBACK_MS = 900;
const ORDERBOOK_PRECISION_CANDIDATE_OPTIONS = [
"0.00000001",
"0.0000001",
Expand Down Expand Up @@ -1939,6 +1940,8 @@
let orderbookPrecisionObserver = null;
let orderbookPrecisionObserverRoot = null;
let lastObservedOrderbookPrecision = null;
let orderbookPrecisionRefreshFeedback = { symbol: null, state: "idle" };
let orderbookPrecisionRefreshFeedbackTimer = null;
let orderbookPrecisionState = {
symbol: null,
samples: [],
Expand Down Expand Up @@ -2791,6 +2794,40 @@
}
return slots;
}
function renderOrderbookPrecisionRefreshButton(symbol, disabled) {
const feedbackState = orderbookPrecisionRefreshFeedback.symbol === symbol ? orderbookPrecisionRefreshFeedback.state : "idle";
const feedback = feedbackState === "success" ? {
label: PANEL_COPY.status.precisionUpdated,
color: "var(--color-Buy)",
icon: '<svg viewBox="0 0 24 24" aria-hidden="true" style="width:17px;height:17px;fill:currentColor;"><path d="m9.55 16.6-4.25-4.25 1.4-1.4 2.85 2.85 7.75-7.75 1.4 1.4Z"></path></svg>'
} : feedbackState === "retry" ? {
label: PANEL_COPY.status.precisionInsufficient,
color: "var(--color-PrimaryYellow)",
icon: '<svg viewBox="0 0 24 24" aria-hidden="true" style="width:17px;height:17px;fill:currentColor;"><path d="M11 6h2v8h-2V6Zm0 10h2v2h-2v-2Z"></path></svg>'
} : {
label: formatPrecisionRefreshTooltip(ORDERBOOK_PRECISION_INITIAL_TRADE_LIMIT),
color: CONTROL_TEXT_COLOR,
icon: '<svg viewBox="0 0 24 24" aria-hidden="true" style="width:16px;height:16px;fill:currentColor;"><path d="M19.5 7.2A8 8 0 1 0 20 15h-2.25a6 6 0 1 1-.1-5.8L15 12h7V5l-2.5 2.2Z"></path></svg>'
};
const disabledAttrs = disabled ? ' disabled aria-disabled="true"' : "";
return `<button type="button" data-orderbook-precision-refresh="true" data-orderbook-precision-refresh-state="${feedbackState}"${disabledAttrs} title="${feedback.label}" aria-label="${feedback.label}" aria-live="polite" style="width:32px;height:32px;padding:0;border-radius:6px;border:1px solid ${CONTROL_BORDER_COLOR};display:flex;align-items:center;justify-content:center;${NEUTRAL_CONTROL_STYLE}color:${feedback.color};">${feedback.icon}</button>`;
}
function showOrderbookPrecisionRefreshFeedback(symbol, state) {
if (!["success", "retry"].includes(state)) {
throw new Error(`Invalid orderbook precision refresh feedback state: ${state}`);
}
if (orderbookPrecisionRefreshFeedbackTimer !== null) {
window.clearTimeout(orderbookPrecisionRefreshFeedbackTimer);
}
orderbookPrecisionRefreshFeedback = { symbol, state };
refreshOrderbookPrecisionRecommendation();
orderbookPrecisionRefreshFeedbackTimer = window.setTimeout(() => {
orderbookPrecisionRefreshFeedbackTimer = null;
if (orderbookPrecisionRefreshFeedback.symbol !== symbol || orderbookPrecisionRefreshFeedback.state !== state) return;
orderbookPrecisionRefreshFeedback = { symbol, state: "idle" };
refreshOrderbookPrecisionRecommendation();
}, ORDERBOOK_PRECISION_REFRESH_FEEDBACK_MS);
}
function refreshOrderbookPrecisionRecommendation(panel = document.getElementById(PANEL_ID)) {
const el = panel?.querySelector?.(`#${ORDERBOOK_PRECISION_RECOMMENDATION_ID}`);
if (!el) return;
Expand Down Expand Up @@ -2824,13 +2861,12 @@
);
if (!nativeOptions.length) queueOrderbookPrecisionOptionsLoad(symbol);
const canRefresh = !controlsBusy;
const refreshTooltip = formatPrecisionRefreshTooltip(ORDERBOOK_PRECISION_INITIAL_TRADE_LIMIT);
const recommendationHtml = [
'<div style="margin-top:10px;">',
'<div style="display:grid;grid-template-columns:36px repeat(4,minmax(0,1fr)) 32px;align-items:center;gap:4px;height:32px;overflow:hidden;">',
`<span title="${PANEL_COPY.tooltip.pricePrecision}" style="color:${MUTED_TEXT_COLOR};font-size:13px;white-space:nowrap;cursor:help;">${PANEL_COPY.field.pricePrecision}</span>`,
...renderOrderbookPrecisionShortcutSlots(shortcutOptions, current, recommendation, controlsBusy),
`<button type="button" data-orderbook-precision-refresh="true"${canRefresh ? "" : ' disabled aria-disabled="true"'} title="${refreshTooltip}" aria-label="${refreshTooltip}" style="width:32px;height:32px;padding:0;border-radius:6px;border:1px solid ${CONTROL_BORDER_COLOR};display:flex;align-items:center;justify-content:center;${NEUTRAL_CONTROL_STYLE}"><svg viewBox="0 0 24 24" aria-hidden="true" style="width:16px;height:16px;fill:currentColor;"><path d="M19.5 7.2A8 8 0 1 0 20 15h-2.25a6 6 0 1 1-.1-5.8L15 12h7V5l-2.5 2.2Z"></path></svg></button>`,
renderOrderbookPrecisionRefreshButton(symbol, !canRefresh),
"</div>",
"</div>"
].join("");
Expand Down Expand Up @@ -3041,6 +3077,7 @@
setLadderStatus(
recommendation ? PANEL_COPY.status.precisionUpdated : PANEL_COPY.status.precisionInsufficient
);
showOrderbookPrecisionRefreshFeedback(symbol, recommendation ? "success" : "retry");
scheduleRenderPanel();
}
function getBufferedMakerPrices(side, levels, ladderStep = DEFAULT_LADDER_STEP) {
Expand Down
54 changes: 51 additions & 3 deletions src/binance-orderbook-trade/index.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// @namespace binance.orderbook.trade
// @icon data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @icon64 data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @version 2.7.127
// @version 2.7.128
// @author jackhai9
// @description 单击订单簿价格，按当前开仓/平仓 tab 自动填数量并执行下单，内置数量倍率面板
// @match https://www.binance.com/*/futures/*
Expand Down Expand Up @@ -274,6 +274,7 @@ import {
const ORDERBOOK_PRECISION_TRADE_EXPANSION_STEP = 10;
const ORDERBOOK_PRECISION_MIN_EFFECTIVE_MOVES = 5;
const ORDERBOOK_PRECISION_SHORTCUT_LIMIT = 4;
const ORDERBOOK_PRECISION_REFRESH_FEEDBACK_MS = 900;
const ORDERBOOK_PRECISION_CANDIDATE_OPTIONS = [
'0.00000001',
'0.0000001',
Expand Down Expand Up @@ -362,6 +363,8 @@ import {
let orderbookPrecisionObserver = null;
let orderbookPrecisionObserverRoot = null;
let lastObservedOrderbookPrecision = null;
let orderbookPrecisionRefreshFeedback = { symbol: null, state: 'idle' };
let orderbookPrecisionRefreshFeedbackTimer = null;
let orderbookPrecisionState = {
symbol: null,
samples: [],
Expand Down Expand Up @@ -1475,6 +1478,51 @@ import {
return slots;
}

function renderOrderbookPrecisionRefreshButton(symbol, disabled) {
const feedbackState = orderbookPrecisionRefreshFeedback.symbol === symbol
? orderbookPrecisionRefreshFeedback.state
: 'idle';
const feedback = feedbackState === 'success'
? {
label: PANEL_COPY.status.precisionUpdated,
color: 'var(--color-Buy)',
icon: '<svg viewBox="0 0 24 24" aria-hidden="true" style="width:17px;height:17px;fill:currentColor;"><path d="m9.55 16.6-4.25-4.25 1.4-1.4 2.85 2.85 7.75-7.75 1.4 1.4Z"></path></svg>',
}
: feedbackState === 'retry'
? {
label: PANEL_COPY.status.precisionInsufficient,
color: 'var(--color-PrimaryYellow)',
icon: '<svg viewBox="0 0 24 24" aria-hidden="true" style="width:17px;height:17px;fill:currentColor;"><path d="M11 6h2v8h-2V6Zm0 10h2v2h-2v-2Z"></path></svg>',
}
: {
label: formatPrecisionRefreshTooltip(ORDERBOOK_PRECISION_INITIAL_TRADE_LIMIT),
color: CONTROL_TEXT_COLOR,
icon: '<svg viewBox="0 0 24 24" aria-hidden="true" style="width:16px;height:16px;fill:currentColor;"><path d="M19.5 7.2A8 8 0 1 0 20 15h-2.25a6 6 0 1 1-.1-5.8L15 12h7V5l-2.5 2.2Z"></path></svg>',
};
const disabledAttrs = disabled ? ' disabled aria-disabled="true"' : '';
return `<button type="button" data-orderbook-precision-refresh="true" data-orderbook-precision-refresh-state="${feedbackState}"${disabledAttrs} title="${feedback.label}" aria-label="${feedback.label}" aria-live="polite" style="width:32px;height:32px;padding:0;border-radius:6px;border:1px solid ${CONTROL_BORDER_COLOR};display:flex;align-items:center;justify-content:center;${NEUTRAL_CONTROL_STYLE}color:${feedback.color};">${feedback.icon}</button>`;
}

function showOrderbookPrecisionRefreshFeedback(symbol, state) {
if (!['success', 'retry'].includes(state)) {
throw new Error(`Invalid orderbook precision refresh feedback state: ${state}`);
}
if (orderbookPrecisionRefreshFeedbackTimer !== null) {
window.clearTimeout(orderbookPrecisionRefreshFeedbackTimer);
}
orderbookPrecisionRefreshFeedback = { symbol, state };
refreshOrderbookPrecisionRecommendation();
orderbookPrecisionRefreshFeedbackTimer = window.setTimeout(() => {
orderbookPrecisionRefreshFeedbackTimer = null;
if (
orderbookPrecisionRefreshFeedback.symbol !== symbol
|| orderbookPrecisionRefreshFeedback.state !== state
) return;
orderbookPrecisionRefreshFeedback = { symbol, state: 'idle' };
refreshOrderbookPrecisionRecommendation();
}, ORDERBOOK_PRECISION_REFRESH_FEEDBACK_MS);
}

function refreshOrderbookPrecisionRecommendation(panel = document.getElementById(PANEL_ID)) {
const el = panel?.querySelector?.(`#${ORDERBOOK_PRECISION_RECOMMENDATION_ID}`);
if (!el) return;
Expand Down Expand Up @@ -1517,13 +1565,12 @@ import {
);
if (!nativeOptions.length) queueOrderbookPrecisionOptionsLoad(symbol);
const canRefresh = !controlsBusy;
const refreshTooltip = formatPrecisionRefreshTooltip(ORDERBOOK_PRECISION_INITIAL_TRADE_LIMIT);
const recommendationHtml = [
'<div style="margin-top:10px;">',
'<div style="display:grid;grid-template-columns:36px repeat(4,minmax(0,1fr)) 32px;align-items:center;gap:4px;height:32px;overflow:hidden;">',
`<span title="${PANEL_COPY.tooltip.pricePrecision}" style="color:${MUTED_TEXT_COLOR};font-size:13px;white-space:nowrap;cursor:help;">${PANEL_COPY.field.pricePrecision}</span>`,
...renderOrderbookPrecisionShortcutSlots(shortcutOptions, current, recommendation, controlsBusy),
`<button type="button" data-orderbook-precision-refresh="true"${canRefresh ? '' : ' disabled aria-disabled="true"'} title="${refreshTooltip}" aria-label="${refreshTooltip}" style="width:32px;height:32px;padding:0;border-radius:6px;border:1px solid ${CONTROL_BORDER_COLOR};display:flex;align-items:center;justify-content:center;${NEUTRAL_CONTROL_STYLE}"><svg viewBox="0 0 24 24" aria-hidden="true" style="width:16px;height:16px;fill:currentColor;"><path d="M19.5 7.2A8 8 0 1 0 20 15h-2.25a6 6 0 1 1-.1-5.8L15 12h7V5l-2.5 2.2Z"></path></svg></button>`,
renderOrderbookPrecisionRefreshButton(symbol, !canRefresh),
'</div>',
'</div>',
].join('');
Expand Down Expand Up @@ -1770,6 +1817,7 @@ import {
? PANEL_COPY.status.precisionUpdated
: PANEL_COPY.status.precisionInsufficient
);
showOrderbookPrecisionRefreshFeedback(symbol, recommendation ? 'success' : 'retry');
scheduleRenderPanel();
}

Expand Down
14 changes: 11 additions & 3 deletions test/unit/binance-orderbook-trade/source-regressions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,13 +962,20 @@ test('orderbook precision recommendation marks one shortcut without applying it
assert.doesNotMatch(sampleBody, /getCurrentOrderbookDisplayStep|fallbackMovement/);

const refreshBody = readFunctionBody('refreshOrderbookPrecisionRecommendation');
const refreshButtonBody = readFunctionBody('renderOrderbookPrecisionRefreshButton');
const refreshFeedbackBody = readFunctionBody('showOrderbookPrecisionRefreshFeedback');
assert.match(refreshBody, /recommendOrderbookPrecision/);
assert.doesNotMatch(refreshBody, /resolveOrderbookPrecisionSampleState|orderbookPrecisionSampleTimer/);
assert.match(refreshBody, /data-orderbook-precision-refresh="true"[\s\S]*disabled/);
assert.match(refreshButtonBody, /data-orderbook-precision-refresh="true"[\s\S]*disabled/);
assert.match(refreshButtonBody, /data-orderbook-precision-refresh-state="\$\{feedbackState\}"/);
assert.match(refreshButtonBody, /PANEL_COPY\.status\.precisionUpdated/);
assert.match(refreshButtonBody, /PANEL_COPY\.status\.precisionInsufficient/);
assert.match(refreshFeedbackBody, /ORDERBOOK_PRECISION_REFRESH_FEEDBACK_MS/);
assert.match(sampleBody, /showOrderbookPrecisionRefreshFeedback\(symbol, recommendation \? 'success' : 'retry'\)/);
assert.match(refreshBody, /const controlsBusy = selectionBusy/);
assert.match(refreshBody, /getOrderbookPrecisionShortcutOptions\([\s\S]*ORDERBOOK_PRECISION_SHORTCUT_LIMIT/);
assert.match(refreshBody, /queueOrderbookPrecisionOptionsLoad\(symbol\)/);
assert.match(refreshBody, /formatPrecisionRefreshTooltip\(ORDERBOOK_PRECISION_INITIAL_TRADE_LIMIT\)/);
assert.match(refreshButtonBody, /formatPrecisionRefreshTooltip\(ORDERBOOK_PRECISION_INITIAL_TRADE_LIMIT\)/);
const shortcutBody = readFunctionBody('renderOrderbookPrecisionShortcut');
assert.match(shortcutBody, /const recommended = value === recommendation/);
assert.match(shortcutBody, /position:absolute;top:3px;right:3px;width:6px;height:6px/);
Expand All @@ -987,7 +994,8 @@ test('orderbook precision recommendation marks one shortcut without applying it
assert.match(refreshBody, /PANEL_COPY\.tooltip\.pricePrecision/);
assert.match(refreshBody, /renderOrderbookPrecisionShortcutSlots\(shortcutOptions, current, recommendation, controlsBusy\)/);
assert.match(refreshBody, /grid-template-columns:36px repeat\(4,minmax\(0,1fr\)\) 32px/);
assert.match(refreshBody, /data-orderbook-precision-refresh="true"[^`]*<svg/);
assert.match(refreshBody, /renderOrderbookPrecisionRefreshButton\(symbol, !canRefresh\)/);
assert.match(refreshButtonBody, /data-orderbook-precision-refresh="true"[^`]*\$\{feedback\.icon\}/);
assert.doesNotMatch(refreshBody, /data-orderbook-precision-status/);

assert.equal((source.match(/PANEL_COPY\.field\.interval, PANEL_COPY\.tooltip\.interval, LADDER_STEP_OPTIONS/g) || []).length, 2);
Expand Down
Loading