Skip to content

Fix Binance trade input React rollback - #196

Merged
jackhai9 merged 1 commit into
mainfrom
codex/fix-trade-input-react-rollback
Aug 27, 2026
Merged

jackhai9 merged 1 commit into
mainfrom
codex/fix-trade-input-react-rollback

Conversation

@jackhai9

Copy link
Copy Markdown
Owner

Summary

  • recover one exact same-node React rollback after consecutive stable frame observations
  • cancel recovery when the rollback value changes, preserving fail-closed behavior for concurrent edits and repeated rejection
  • add behavioral coverage for bounded recovery, replacement identities, and rejection paths
  • bump the generated userscript to v2.7.135

Root cause evidence

  • live CDP captured one unique visible trade form and the same quantity input identity throughout the failure
  • the userscript wrote 0.07, Binance React restored the same input to an empty value within about 3 ms, and the previous one-write WeakSet then waited until the 350 ms timeout
  • the failure occurs before the Binance submit button is clicked and is unrelated to network timeouts

Validation

  • npm run build:binance-orderbook-trade
  • npm test (364/364)
  • npm run check:binance-orderbook-trade
  • git diff --check
  • independent read-only review: pass after narrowing recovery to the exact first rollback value

@jackhai9
jackhai9 merged commit 290d8d9 into main Aug 27, 2026
1 check passed
@jackhai9
jackhai9 deleted the codex/fix-trade-input-react-rollback branch August 27, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant