Skip to content

Match Binance ladder normalized empty rollback #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackhai9 merged 1 commit into from
Aug 27, 2026
Merged

Match Binance ladder normalized empty rollback #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/binance-orderbook-trade.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// @namespace binance.orderbook.trade
// @icon data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @icon64 data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @version 2.7.137
// @version 2.7.138
// @author jackhai9
// @description 单击订单簿价格，按当前开仓/平仓 tab 自动填数量并执行下单，内置数量倍率面板
// @match https://www.binance.com/*/futures/*
Expand Down Expand Up @@ -3678,7 +3678,7 @@
const syncTimeoutMs = settleControlledForm ? LADDER_INPUT_SETTLE_TIMEOUT_MS : TRADE_INPUT_SYNC_TIMEOUT_MS;
const stableMismatchFrames = settleControlledForm ? LADDER_INPUT_SETTLE_MISMATCH_FRAMES : TRADE_INPUT_SYNC_STABLE_FRAMES;
const maxWriteAttempts = settleControlledForm ? LADDER_INPUT_SETTLE_MAX_WRITES : 2;
const isRecoveryWriteAllowed = settleControlledForm ? ({ rollbackValue }) => rollbackValue === "" : () => true;
const isRecoveryWriteAllowed = settleControlledForm ? ({ rollbackValue }) => rollbackValue === null : () => true;
const writeTradeInputValue = settleControlledForm ? createBoundedInputWriter({
writeValue: setInputValueReact,
maxWriteAttempts
Expand Down
4 changes: 2 additions & 2 deletions src/binance-orderbook-trade/index.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// @namespace binance.orderbook.trade
// @icon data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @icon64 data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @version 2.7.137
// @version 2.7.138
// @author jackhai9
// @description 单击订单簿价格，按当前开仓/平仓 tab 自动填数量并执行下单，内置数量倍率面板
// @match https://www.binance.com/*/futures/*
Expand Down Expand Up @@ -2248,7 +2248,7 @@ import {
? LADDER_INPUT_SETTLE_MAX_WRITES
: 2;
const isRecoveryWriteAllowed = settleControlledForm
? ({ rollbackValue }) => rollbackValue === ''
? ({ rollbackValue }) => rollbackValue === null
: () => true;
const writeTradeInputValue = settleControlledForm
? createBoundedInputWriter({
Expand Down
5 changes: 5 additions & 0 deletions test/unit/binance-orderbook-trade/source-regressions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,11 @@ test('trade input synchronization confirms live controlled values instead of sle
(syncBody.match(/recoverProvisionalMatchRollback:\s*settleControlledForm/g) || []).length,
2,
);
assert.match(
syncBody,
/\?\s*\(\{\s*rollbackValue\s*\}\)\s*=>\s*rollbackValue\s*===\s*null/,
);
assert.doesNotMatch(syncBody, /rollbackValue\s*===\s*''/);
assert.match(syncBody, /settleControlledForm[\s\S]*LADDER_INPUT_SETTLE_MISMATCH_FRAMES/);
assert.match(syncBody, /waitForTradeFormFrameState/);
assert.match(syncBody, /includePrice:\s*false/);
Expand Down
42 changes: 23 additions & 19 deletions test/unit/binance-orderbook-trade/trade-form.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ import {
waitForTradeFormFrameState,
waitForTradeFormMutationState,
} from '../../../src/binance-orderbook-trade/dom/trade-form.js';
import {
compareDecimalStrings,
normalizeDecimalString,
} from '../../../src/binance-orderbook-trade/core/decimal.js';
import { loadFixtureDom } from '../../helpers/dom.js';

const fixture = await readFile(
Expand Down Expand Up @@ -356,8 +360,8 @@ test('trade input synchronization performs one post-transition write after a sta
expectedPrice: '81.9',
expectedQty: '0.01',
includePrice: true,
normalizeValue: String,
compareValues: (expected, actual) => expected === actual ? 0 : 1,
normalizeValue: normalizeDecimalString,
compareValues: compareDecimalStrings,
writeValue: (input, value) => {
writes.push({ input, value });
if (input === currentInputs.qtyInput) {
Expand Down Expand Up @@ -395,8 +399,8 @@ test('trade input synchronization can settle a ladder input after repeated stabl
resolveInputs: () => currentInputs,
expectedQty: '0.02',
includePrice: false,
normalizeValue: String,
compareValues: (expected, actual) => expected === actual ? 0 : 1,
normalizeValue: normalizeDecimalString,
compareValues: compareDecimalStrings,
writeValue: (input, value) => {
writes.push({ input, value });
qtyWrites += 1;
Expand All @@ -405,7 +409,7 @@ test('trade input synchronization can settle a ladder input after repeated stabl
requiredStableMismatchFrames: 2,
maxWriteAttempts: 5,
isRecoveryWriteAllowed: ({ currentInput, rollbackValue }) => (
currentInput === currentInputs.qtyInput && rollbackValue === ''
currentInput === currentInputs.qtyInput && rollbackValue === null
),
});

Expand All @@ -432,8 +436,8 @@ test('trade input synchronization recovers a provisional match rolled back befor
resolveInputs: () => currentInputs,
expectedQty: '0.07',
includePrice: false,
normalizeValue: String,
compareValues: (expected, actual) => expected === actual ? 0 : 1,
normalizeValue: normalizeDecimalString,
compareValues: compareDecimalStrings,
writeValue: (input, value) => {
writes.push({ input, value });
input.value = value;
Expand All @@ -442,7 +446,7 @@ test('trade input synchronization recovers a provisional match rolled back befor
requiredStableMatchFrames: 2,
maxWriteAttempts: 5,
recoverProvisionalMatchRollback: true,
isRecoveryWriteAllowed: ({ rollbackValue }) => rollbackValue === '',
isRecoveryWriteAllowed: ({ rollbackValue }) => rollbackValue === null,
});

assert.equal(readState(), null);
Expand All @@ -468,8 +472,8 @@ test('trade input synchronization cancels provisional recovery for a different n
resolveInputs: () => currentInputs,
expectedQty: '0.07',
includePrice: false,
normalizeValue: String,
compareValues: (expected, actual) => expected === actual ? 0 : 1,
normalizeValue: normalizeDecimalString,
compareValues: compareDecimalStrings,
writeValue: (input, value) => {
writes.push({ input, value });
input.value = value;
Expand All @@ -478,7 +482,7 @@ test('trade input synchronization cancels provisional recovery for a different n
requiredStableMatchFrames: 2,
maxWriteAttempts: 5,
recoverProvisionalMatchRollback: true,
isRecoveryWriteAllowed: ({ rollbackValue }) => rollbackValue === '',
isRecoveryWriteAllowed: ({ rollbackValue }) => rollbackValue === null,
});

assert.equal(readState(), null);
Expand All @@ -501,16 +505,16 @@ test('trade input synchronization rejects a provisionally accepted value that ro
resolveInputs: () => currentInputs,
expectedQty: '0.19',
includePrice: false,
normalizeValue: String,
compareValues: (expected, actual) => expected === actual ? 0 : 1,
normalizeValue: normalizeDecimalString,
compareValues: compareDecimalStrings,
writeValue: (input, value) => {
writes.push({ input, value });
input.value = value;
},
requiredStableMismatchFrames: 2,
requiredStableMatchFrames: 3,
maxWriteAttempts: 5,
isRecoveryWriteAllowed: ({ rollbackValue }) => rollbackValue === '',
isRecoveryWriteAllowed: ({ rollbackValue }) => rollbackValue === null,
});

assert.equal(readState(), null);
Expand Down Expand Up @@ -557,8 +561,8 @@ test('trade input synchronization remains fail-closed after the post-transition
resolveInputs: () => currentInputs,
expectedQty: '0.01',
includePrice: false,
normalizeValue: String,
compareValues: (expected, actual) => expected === actual ? 0 : 1,
normalizeValue: normalizeDecimalString,
compareValues: compareDecimalStrings,
writeValue: (input, value) => {
writes.push({ input, value });
input.value = '';
Expand All @@ -584,15 +588,15 @@ test('trade input synchronization never exceeds an expanded write-attempt budget
resolveInputs: () => currentInputs,
expectedQty: '0.02',
includePrice: false,
normalizeValue: String,
compareValues: (expected, actual) => expected === actual ? 0 : 1,
normalizeValue: normalizeDecimalString,
compareValues: compareDecimalStrings,
writeValue: (input, value) => {
writes.push({ input, value });
input.value = '';
},
requiredStableMismatchFrames: 1,
maxWriteAttempts: 3,
isRecoveryWriteAllowed: ({ rollbackValue }) => rollbackValue === '',
isRecoveryWriteAllowed: ({ rollbackValue }) => rollbackValue === null,
});

for (let frame = 0; frame < 10; frame += 1) {
Expand Down
Loading