Skip to content

Fix close ladder completion when position is flat - #226

Merged
jackhai9 merged 1 commit into
mainfrom
codex/complete-continuous-close-when-flat
Aug 30, 2026
Merged

jackhai9 merged 1 commit into
mainfrom
codex/complete-continuous-close-when-flat

Conversation

@jackhai9

Copy link
Copy Markdown
Owner

Summary

  • confirm the exact LONG or SHORT position through the current Binance position response before classifying close-ladder exhaustion
  • end single and continuous close ladders normally when the requested direction is confirmed flat
  • retain failures for unknown submission outcomes, symbol or mode changes, and unresolved dialogs
  • add unit and source-contract coverage for flat completion and asynchronous readiness

Validation

  • npm test (442 passed)
  • npm run build:binance-orderbook-trade
  • npm run check:binance-orderbook-trade
  • git diff --check

@jackhai9
jackhai9 merged commit b8b1d58 into main Aug 30, 2026
1 check passed
@jackhai9
jackhai9 deleted the codex/complete-continuous-close-when-flat branch August 30, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant