Repository navigation
fix(strategy29): retain recent summary progress across visibility changes - #275
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8493f0bc4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Strategy29 could replay retained global history after opening a summary or returning to a hidden page, delaying recent signals. Start with the server's bounded latest-symbol snapshot, follow its global increment cursor, and preserve the current client's cursor and rows across visibility pauses. Reject cancelled responses before they can publish state or clear a resumed request's in-flight flag.
Keep recent rows in durable sequence order and recover expired cursors with another latest snapshot. Publish userscript 0.2.1 with unchanged detector bytes and install/update URLs. Server dependency: https://github.com/jackhai9/CorsairQuant/pull/328 must be deployed before this client is published.
Validation
Installed-source readback/reload and the affected non-financial live page path follow publication. This change does not enable the production observer, gateway or notifications.
Permanent runtime failures dispose the remote panel and pending request. Regression tests cover an embedded-observer conflict and native interval-subscription failure after the panel has populated, including late response and pageshow behavior.
The default test command explicitly selects every unit/DOM test file, so manual previews and the external TradingView demo probe are not executed accidentally. An earlier bare-discovery run failed on that network probe and a 100 ms coalescer deadline under concurrent suites; all actual tests passed both in isolation and through the corrected default command, with the coalescer deadline and assertions unchanged.