Skip to content

fix(strategy29): preserve fatal local monitor diagnostics - #276

Merged
jackhai9 merged 3 commits into
mainfrom
codex/strategy29-local-failure-diagnostics
Sep 6, 2026
Merged

jackhai9 merged 3 commits into
mainfrom
codex/strategy29-local-failure-diagnostics

Conversation

@jackhai9

@jackhai9 jackhai9 commented Sep 6, 2026 •

Copy link
Copy Markdown
Owner

Local Bollinger monitoring can enter its existing fatal state and clear its marker layer while the outer runtime remains healthy. Version 0.2.1 loses the local failure cause after cleanup, leaving source inspection unable to identify the failing chart operation.

Retain one bounded, read-only lastLocalFailure with the export/detect/reconcile/render stage, thrown value type, available name/message, chart context and pre-cleanup counts. The record survives cleanup and stop. String and non-Error host rejections are represented without serializing arbitrary objects. Each name/message field is read once within a narrow diagnostic boundary; throwing accessors are identified in unreadableFields. Unclassifiable host Proxy rejections explicitly stop the monitor and record classificationFailed. Normal fatal classification, snapshot-race recovery, marker rendering and the frozen detector/core remain unchanged. Publish the generated observer as 0.2.2.

Validation: 824 unit/DOM tests passed; all 64 browser fixture tests passed before the rejection serialization corrections and the two affected generated coexistence cases passed again on the final artifact; Binance userscript syntax checks passed; the real Python gateway/generated JavaScript contract verifier passed for 0.2.2, including latest sequences [2, 3], following increment [4] and HTTP 400/401/409/503. Source and generated metadata match, with unchanged update URLs.

This is diagnostic instrumentation, not a claim that the intermittent local chart failure is fixed. Production Strategy29 activation and notifications remain outside this change. Exact installed-source and live diagnostics checks follow publication.

@jackhai9

jackhai9 commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-06T02:35:35.426724Z 21adf74 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5950e8e1eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/binance-strategy29-bollinger/monitor.js Outdated
@jackhai9

jackhai9 commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4ccf5038a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/binance-strategy29-bollinger/monitor.js
@jackhai9

jackhai9 commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 21adf7444a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jackhai9
jackhai9 merged commit 0b6c6bd into main Sep 6, 2026
2 checks passed
@jackhai9
jackhai9 deleted the codex/strategy29-local-failure-diagnostics branch September 8, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant