fix(orderbook): recover continuous close reduce-only conflicts - #281
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuous close previously stopped on a second reduce-only rejection even when fills had changed the position. Version 2.7.202 recovers confirmed 90802022 responses by rechecking the same-side position, capping rebuilt plans by both API position and current DOM closeable quantity, and ending normally when flat. An unchanged position permits one scoped Basic-order replacement; another rejection without real position reduction stops with its original reason. Once this recovery starts, unrelated capacity recovery and uncertain action results cannot trigger further cancellations or submissions.
Validation: full unit/DOM suite passed on the release branch; build, syntax, metadata, and diff checks passed. Three generated-script Playwright scenarios passed for repeated rejections with partial submissions, flat detection while the native button is disabled, and a later capacity rejection without batch cancellation. Independent read-only review passed after its findings were fixed. Live Tampermonkey sync and loaded-source verification follow merge; no financial actions are part of validation.