Repository navigation
fix: keep order notification filtering after native variable renaming - #310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep ordinary Binance order toasts and sound scoped to the current symbol after frontend variable renaming or reformatting. OUSDT and encoded 龙虾USDT were receiving USUSDT sounds because an equivalent sound factory had different local names; USUSDT and AINUSDT had active filtering.
Replace exact source matching with Acorn and eslint-scope structural signatures. Local declarations and resolved references are normalized; globals, property names, module IDs, event fields, control flow, directives and side effects remain exact. Pure
!0/!1spellings also match boolean literals. Equivalent modules select precompiled replacements without evaluating or compiling host code. Nine observed notification sources reduce to three runtime templates.The UI job budget is 15 minutes so the full suite and setup can finish on hosted runners; individual test deadlines and zero retries remain unchanged.
Bundled parser dependencies have fixed versions and included license notices. Coverage builds share the release banner and explicitly clear vendor mappings while preserving the complete project-source denominator.
Validation:
Version: orderbook v2.7.222. Actual upstream behavior changes, unsupported dynamic scope and late injection continue to preserve native handling. The bundle grows by approximately 350 KB for the parser and structural matcher.