Skip to content

fix: keep order notification filtering after native variable renaming - #310

Merged
jackhai9 merged 2 commits into
mainfrom
fix/native-sound-source-variant
Oct 7, 2026
Merged

jackhai9 merged 2 commits into
mainfrom
fix/native-sound-source-variant

Conversation

@jackhai9

@jackhai9 jackhai9 commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Keep ordinary Binance order toasts and sound scoped to the current symbol after frontend variable renaming or reformatting. OUSDT and encoded 龙虾USDT were receiving USUSDT sounds because an equivalent sound factory had different local names; USUSDT and AINUSDT had active filtering.

Replace exact source matching with Acorn and eslint-scope structural signatures. Local declarations and resolved references are normalized; globals, property names, module IDs, event fields, control flow, directives and side effects remain exact. Pure !0/!1 spellings also match boolean literals. Equivalent modules select precompiled replacements without evaluating or compiling host code. Nine observed notification sources reduce to three runtime templates.

The UI job budget is 15 minutes so the full suite and setup can finish on hosted runners; individual test deadlines and zero retries remain unchanged.

Bundled parser dependencies have fixed versions and included license notices. Coverage builds share the release banner and explicitly clear vendor mappings while preserving the complete project-source denominator.

Validation:

  • All 2,357 Node tests passed, including source-map boundaries and both captured sound variants.
  • Five notification browser scenarios passed, including independently renamed and reformatted native factories, USUSDT-to-OUSDT silence and encoded Unicode routes.
  • Eight existing browser performance scenarios passed. In ten isolated Chromium samples, parser loading plus matching three factories took at most 56.1 ms; this is not a live Binance page-load guarantee.
  • Test lint, generated build, syntax and diff checks passed. The rendered notification panel was inspected.
  • Live diagnosis was read-only; no real orders, cancellations or transfers were triggered for testing. Existing pages need a new script load.

Version: orderbook v2.7.222. Actual upstream behavior changes, unsupported dynamic scope and late injection continue to preserve native handling. The bundle grows by approximately 350 KB for the parser and structural matcher.

@jackhai9 jackhai9 closed this Oct 7, 2026
@jackhai9 jackhai9 reopened this Oct 7, 2026
@jackhai9
jackhai9 merged commit 551b967 into main Oct 7, 2026
3 checks passed
@jackhai9
jackhai9 deleted the fix/native-sound-source-variant branch October 7, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant