-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(download): show saved file path in web read and weixin download output #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -56,6 +56,7 @@ export interface ArticleDownloadResult { | |||||
| publish_time: string; | ||||||
| status: string; | ||||||
| size: string; | ||||||
| saved: string; | ||||||
|
||||||
| saved: string; | |
| saved?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
columnsadds the newsavedfield, but not all return paths in this command include it. In particular, the invalid-URL early return a few lines below returns an object withoutsaved, which makes output schema inconsistent. Update that return object to includesaved: '-'as well.