fix(twitter): use pushState for search SPA navigation#105
Open
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Open
fix(twitter): use pushState for search SPA navigation#105Astro-Han wants to merge 1 commit intojackwener:mainfrom
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Conversation
…PA navigation The previous approach (nativeSetter + Enter keydown on the search input) does not reliably trigger Twitter's form submission - the synthetic KeyboardEvent is ignored by React, leaving the page on /explore with zero API calls captured. Use history.pushState + PopStateEvent instead, which triggers React Router's listener and performs a true SPA navigation to /search. The interceptor survives because no full page reload occurs. Tested: "opencli", "it's a test" (single quote), "hello" all return results with correct author attribution.
Astro-Han
force-pushed
the
worktree-fix-search-nav
branch
from
2f86ffe to
c0f814c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes twitter search returning empty results. The current search input approach (
nativeSetter+KeyboardEvent('keydown', Enter)) does not reliably trigger Twitter's form submission — the synthetic event is ignored by React, leaving the page on/explorewith zero SearchTimeline API calls captured.Replaces with
history.pushState+PopStateEvent('popstate'), which triggers React Router's listener and performs a true SPA navigation to/search?q=...&f=top. The interceptor survives because no full page reload occurs.This is a follow-up to #100 which fixed the interceptor pipeline but kept the upstream search input approach.
Test plan
npm run typecheckpassesnpx vitest run src/— 222 tests passtwitter search --query "opencli" --limit 3— returns results with correct authorstwitter search --query "it's a test"— single quote in query handled safely viaJSON.stringify