fix: support WSL mirrored networking - #274
Merged
jacob-bd merged 1 commit intoJul 28, 2026
Merged
Conversation
Premshay
marked this pull request as ready for review
July 27, 2026 18:01
jacob-bd
added a commit
that referenced
this pull request
Jul 28, 2026
- Skip firewall rule prompt in mirrored mode (loopback traffic never crosses Windows Firewall, so the rule is unnecessary) - Include the polled CDP URL in the timeout error message so wrong-IP issues are immediately visible - Adjust troubleshooting steps per networking mode: mirrored mode suggests checking the portproxy rule instead of the firewall rule Follow-up to #273 / #274.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wslinfo --networking-modeRoot cause
get_windows_host_ip()assumed the default gateway was always the Windows host. That is truefor WSL2 NAT networking, but in mirrored mode the gateway can be the physical network router.
As a result,
nlm login --wslpolled the wrong host for Chrome DevTools Protocol and timed out.In mirrored mode, Windows and WSL share loopback, so the correct host address is
127.0.0.1.If the networking-mode probe is unavailable or does not report
mirrored, the existing NATdiscovery path remains unchanged.
Closes #273.
Validation
uv run ruff check .uv run ruff format --check .uv run --dev --with pytest-github-actions-annotate-failures --with pytest-asyncio pytest -v --tb=short -m "not e2e": 1,247 passed, 37 skipped, 1 deselectednlm login --wslon WSL2 mirrored networking