Skip to content

CONNECTION_DRAINING #14

Description

@Saivenkatesh

The connection draining control message does not have data.message_id set, currently the code is not handling the message because of this. The check should be removed for control messages.

Activity

  1. jacobp100 commented on May 26, 2016

    @jacobp100
    Owner

    Do you know what the expected behavior is? Is the check for data.message_id not needed?

  2. Saivenkatesh commented on May 26, 2016

    @Saivenkatesh
    Author

    According to the spec https://developers.google.com/cloud-messaging/ccs#response the expected format for the connection draining message(this is the only control message) is

       <message>
        <data:gcm xmlns:data="google:mobile:data">
        {
         "message_type":"control"
         "control_type":"CONNECTION_DRAINING"
        }
        </data:gcm>
       </message>
    
    

    The other type of messages from the google servers will contain a message_id, but don't think we need to have the check assuming GCM sticks to the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions