Repository navigation
fix(wizard): tri-state reachability (#64) - #66
Merged
Merged
Conversation
jacobyoby
marked this pull request as ready for review
September 9, 2026 19:16
…uiet Route wizard discovery and connectivity checks through Test-DeviceReachability so local send failures stay $null (Unknown) rather than collapsing to false. Forward optional -TcpFallbackPort and report reachable/unreachable/unknown counts. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/wizard-tri-state-reachability-390b
branch
from
September 9, 2026 19:17
385bdc0 to
02f0421
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64.
The quick-start wizard assigned
Test-Connection -Quietbooleans ontoReachable, collapsing local send failures and ICMP-blocked hosts into$false. DrawIO then painted those nodes Unreachable (red) instead of Unknown (gray), undoing the tri-state honesty from #28.Changes
[4/5] Testing connectivitythroughTest-DeviceReachability(true/false/$null).Reachablevalues; a stubbed local-send failure stays$null.-TcpFallbackPorton the wizard and forward it to the same helper.MaxParallel20) and leave-DnsTimeoutSecondsin place for reverse DNS.Tests
$null, summary counts, and discovery returning only confirmed-reachable hosts.Notes
Do not merge until CI is green.