Repository navigation
feat(snmp): allow IPv6 CIDR keys in credential maps - #79
Merged
Merged
Conversation
Resolve-SnmpCredentialConfig now parses IPv4 and IPv6 CIDR keys and keeps longest-prefix matching. Mixed-family maps do not throw; wrong-family lookups return no credential. Invalid CIDRs still fail closed. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74.
Problem
Resolve-SnmpCredentialConfigonly accepted IPv4 CIDR keys, so dual-stack sites could not scope SNMP credentials to IPv6 prefixes after #57/#68.Change
[System.Net.IPAddress]::TryParse(same path as inventory /Invoke-SnmpWalk).Default); it does not throw.[Unreleased]bullet; credential-matching help/template text now says IPv4 or IPv6.Out of scope
CI smoke, Gallery release, SnmpWalk (#78), NetBox (#77), MCP.
Verification
./tests/run-tests.sh(pwsh 7.4.19 / Pester 6.2.0). 162 passed, 0 failed. Touched tests areSNMP credential-map IPv6 CIDR keys (#74)plus the existing#17IPv4 regression cases.