Skip to content

fix: accept IPv6 TargetIP in Invoke-SnmpWalk #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slsgzs-cloud wants to merge 1 commit into from
Closed

fix: accept IPv6 TargetIP in Invoke-SnmpWalk #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions NetDiagram-PS/Public/Invoke-SnmpWalk.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function Invoke-SnmpWalk {
not redacted. Treat SNMP v1/v2c community strings as low-secrecy and prefer SNMPv3
with authentication for anything sensitive.
.PARAMETER TargetIP
IP address or hostname (FQDN) to query. Must not begin with '-'.
IP address (IPv4 or IPv6) or hostname (FQDN) to query. Must not begin with '-'.
.PARAMETER Community
SNMP community string. Must not begin with '-' (argument-injection guard).
.PARAMETER OID
Expand All @@ -33,8 +33,11 @@ function Invoke-SnmpWalk {
[Parameter(Mandatory)]
[ValidateScript({
if ($_ -match '^-') { throw "TargetIP must not begin with '-'." }
if ($_ -notmatch '^(?:\d{1,3}(?:\.\d{1,3}){3}|[A-Za-z0-9]([A-Za-z0-9\-]{0,61}[A-Za-z0-9])?(?:\.[A-Za-z0-9]([A-Za-z0-9\-]{0,61}[A-Za-z0-9])?)*)$') {
throw "TargetIP '$_' is not a valid IPv4 address or hostname."
$ip = $null
if (-not [System.Net.IPAddress]::TryParse($_, [ref]$ip)) {
if ($_ -notmatch '^[A-Za-z0-9]([A-Za-z0-9\-]{0,61}[A-Za-z0-9])?(?:\.[A-Za-z0-9]([A-Za-z0-9\-]{0,61}[A-Za-z0-9])?)*$') {
throw "TargetIP '$_' is not a valid IPv4, IPv6, or hostname."
}
}
$true
})]
Expand Down