Repository navigation
fix: P0 research fixes — IPv6 carry, SNMPv3, loader, ARP, DNS task - #88
Merged
Merged
Conversation
- Invoke-PortScan: log banner-grab and closed-port filters via Write-Verbose - Test-DeviceReachability: log TCP fallback failure via Write-Verbose - Get-SnmpNeighbors: Write-Host -> Write-Information -Tags NetDiagram - Add durable Pester coverage for Information stream and closed-port path Fixes PSScriptAnalyzer PSAvoidUsingEmptyCatchBlock / PSAvoidUsingWriteHost
- Get-IPv6CidrScanTarget: carry overflow across bytes (ff+1=100) for /120 - Invoke-SnmpWalk: use -u for v3 (not -c), redact -u, fix LASTEXITCODE path - NetDiagram-PS.psm1: local ErrorActionPreference, fail-fast on missing dirs/files, throw not Write-Error - ConvertFrom-ArpText: macOS/LinuxArp skip with warning not throw, TryParse for IPv4-only drop - Wait-DnsLookupTask: observe faulted task via Exception property, handle IsFaulted/IsCanceled, prevent UnobservedTaskException - Add durable Pester coverage for all 5 fixes (179 tests) Research: P0 batch from 5-lens audit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Research audit (5 lenses) found 18 items. This PR ships the 6 P0 correctness/security fixes:
-c community(wrong) + proc-list leak + LASTEXITCODE no-discrimination — now-ufor v3 with redacted verboseTests: 175→179 Pester, 0 PSScriptAnalyzer Error, durable coverage for all 5 fixes (
P0 research fixesdescribe)Refs: research workflow dd3045e + e64a83c (lint hygiene)