Repository navigation
Modernize: installable package, unified CLI, tests, and CI - #3
Merged
Merged
Conversation
- Extend indicators.csv with roots, Suricata SIDs, and SIEM match fields - Add emsign_indicators.py and export_siem_indicators.py for ingestion - Load scanner/distrust fingerprints from CSV; default certs-dir to certs/ - Document network, host, and SIEM operator steps in README Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
- Add pyproject.toml and src/emsign_g3 with scan, distrust, export, and paths - Entry point emsign-g3 (scan, distrust, export-indicators) - Package data for indicators.csv and intermediate PEMs; env path overrides - Pytest suite and GitHub Actions (Python 3.10/3.12, ruff, optional Suricata) - tools/*.py shims; README install and development sections Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
Resolve conflicts by keeping package layout and tool shims (HEAD). Remove tools/emsign_indicators.py superseded by src/emsign_g3/. Update AGENTS.md cloud instructions for pyproject/emsign-g3 CLI. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Track A of the modernization plan: stdlib-only installable package, unified CLI, automated tests, and GitHub Actions—on top of the operator-playbook indicator centralization.
Changes
pyproject.toml—emsign-g3-distrust0.1.0, Python ≥3.10,[project.scripts]→emsign-g3src/emsign_g3/—scan,distrust,export,indicators,paths,clidata/(wheel), envEMSIGN_G3_INDICATORS_CSV/EMSIGN_G3_CERTS_DIRtests/— 11 pytest cases (indicators, scan_blob, export, load_certs).github/workflows/ci.yml— Python 3.10/3.12 matrix,export-indicators --verify, ruff, pytest; optional Suricata live-firetools/*.py— thin shims +_ensure_src_path.pyfor clone-without-install useTrack B (Sigma generators) deferred to a follow-up PR.
Verification
Note
This branch includes commits from PR #2 (operator playbook). Merge #2 first or merge this as a single stack onto
main.