Repository navigation
feat: weekday hours from library sites, not IMLS weekly totals - #12
Merged
Merged
Conversation
Lead with the product rule (no reviews), add CI badge and app screenshots, and move schema/dev commands below a short try-it path. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
IMLS weekly hours were shown as long floats and phone fields as digit blobs. Round hours to one decimal and display NANP numbers as (201) 420-2346 so the GitHub screenshots and the live finder match. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
Side-by-side finder and outlet captures with formatted contact info, version badge, and a tagline that matches the product page. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
Parse schema.org openingHours and a single unambiguous week from library
sites, store {day, open, close} with source URL, and use that for
open-now / opens-at. Finder no longer pretends "59 h/wk" is a schedule.
Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
Point-in-polygon every outlet against 564 municipal polygons. Alias Roselle Park and record the 20 IMLS systems absent from the NJSL directory so merge.py reports zero unmatched names. Deploy www/ to GitHub Pages from main. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
IMLS hours-per-week is not a schedule. The seeder records per-day open/close from schema.org, microdata, and unambiguous weeks (including Monday–Thursday ranges), plus evidenced services for the largest systems and published admin contact. Tests import site-facts only so they cannot trigger a crawl. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
Reject maps coordinate mailtos, print-vendor and partner inboxes, calendar event pages, books-by-mail forms, and HTML director strings that swallowed the next label. Gmail is allowed only when the local part names a library. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
96 centrals have per-day open/close from the library site (never IMLS weekly totals). Top systems received evidenced services; admin email, contact form, and board URLs are stored only when published. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMLS
hours_open_weeklyis not a schedule. Finder and outlet pages show weekday open/close from the library’s own site (or “Hours not published”). Never52h/wk.What landed
{days:[{day,open,close}], source_url, verified_on}from schema.org, microdata, and a single unambiguous week (including Monday–Thursday ranges). 96 of 295 centrals have a published weekday schedule. The rest stay unpublished.npm run seed:sitescrawled the ~40 largest systems. Recorded only when the link names the service and the destination page still mentions it (notary, meeting rooms, ESL, passports, etc.).municipality_codefrom NJOGIS; NJSLunmatched_system_names: [].www/frommain. Intended long-term host is loam.Finder Hours column for Hoboken: Opens Saturday at 10:00 AM, not h/wk
Hoboken outlet weekday hours table Mon–Sat open times, Sunday closed
hoboken-weekday-hours-demo.mp4
How to review
src/lib/nostos.js(hoursStatus/hoursWeek) andsrc/app.js(finder hours column + outlet table)scripts/parse-hours.mjs,scripts/site-facts.mjs,scripts/seed_from_sites.mjs#/outlet/NJ0148-002: Mon–Thu 10:00 AM–8:00 PM, Fri–Sat 10:00 AM–5:00 PM, Sunday closedTest plan
npm test— hours neverh/wk; board-games ignored; seeder mock writes weekday slotsnpm run check:datanpm run test:e2e— Hoboken finder + outlet weekday tableTo show artifacts inline, enable in settings.