Fix #472 by checking for instrumental markings during bulk search#473
Closed
Coloradohusky wants to merge 1 commit into
Closed
Fix #472 by checking for instrumental markings during bulk search#473Coloradohusky wants to merge 1 commit into
Coloradohusky wants to merge 1 commit into
Conversation
Author
|
Not sure why id3tag.cpp is failing 🤷 |
jacquesh
reviewed
Jul 28, 2025
jacquesh
left a comment
jacquesh
left a comment
Owner
There was a problem hiding this comment.
As called out in the logs, it didn't like the tag source because of the 'track': unreferenced parameter. Looks like that was a new addition with more recent MSVC builds. I wasn't getting it locally until I updated my installation and now I do. That's been fixed in main so if you merge/rebase then it should be happy.
Given the todo I assume you're planning to still do some more work here so I guess I'll hold off on further review until the PR's more complete?
Owner
|
Closing for inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code adds the instrumental checking seen in lyric_search.cpp to ui_lyric_bulk_search.cpp, as the previous code only checked for instrumentals during autoplay. This code also fixes a minor logging bug. Lyrics can still be checked for instrumental songs by running
Search for lyrics (manually).