Enhance mentorship proposal guidelines - #1144
Merged
Merged
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
The changes are documentation-only and the remaining feedback is limited to minor grammar/consistency nits.
Pull request overview
This PR updates the Jaeger mentorship application documentation to make proposal submission expectations clearer and more actionable for applicants, helping mentors evaluate proposals consistently.
Changes:
- Clarifies that proposals should be uploaded directly to the application (preferably as PDF) and not shared as external links.
- Expands proposal guidance with concrete criteria (due diligence, approach, success criteria, timeline, collaboration, evidence).
- Adds emphasis on following project-specific instructions and avoiding generic or invented technical details.
File summaries
| File | Description |
|---|---|
| content/mentorship/applying.md | Expands and clarifies the “Proposal” guidance for mentorship applicants. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Yuri Shkuro <github@ysh.us>
There was a problem hiding this comment.
🟢 Approval recommended
Documentation-only changes look correct and low-risk, with only minor clarity/grammar nits noted.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
content/mentorship/applying.md:31
- The acronyms “RFCs” and “ADRs” are introduced without expansion, which may be unclear to applicants (and may trigger spellcheck). Consider expanding them on first mention and optionally keeping the acronym in parentheses.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.