refactor: remove gRPC/ZMQ service + Docker (single-process app) - #7
Merged
Merged
Conversation
The CP-SAT solve now runs in-process: SolveWorker calls contrail_env.scenario.solve_scenario directly and wires its progress callback to the Qt signal, so the live convergence curve works with no server and no ZMQ broker. The GUI's config/result types are now plain dataclasses (ScenarioConfig / SolveResult) instead of protobuf messages. Deletes service/ (server, client, progress, proto, generated), the Docker image + compose + CI docker jobs, scripts/gen_proto.*, and the grpcio/grpcio-tools/pyzmq core deps. The scenario builder moved to contrail_env/scenario.py; tests/test_scenario.py covers the in-process build + solve (replacing the old gRPC round-trip test).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CP-SAT solve now runs in-process: SolveWorker calls contrail_env.scenario.solve_scenario directly and wires its progress callback to the Qt signal, so the live convergence curve works with no server and no ZMQ broker. The GUI's config/result types are now plain dataclasses (ScenarioConfig / SolveResult) instead of protobuf messages.
Deletes service/ (server, client, progress, proto, generated), the Docker image + compose + CI docker jobs, scripts/gen_proto.*, and the grpcio/grpcio-tools/pyzmq core deps. The scenario builder moved to contrail_env/scenario.py; tests/test_scenario.py covers the in-process build + solve (replacing the old gRPC round-trip test).