Skip to content

add eventlet to timeout long running request#34

Open
abemassry wants to merge 1 commit into
jahschwa:masterfrom
abemassry:timeout-link_echo
Open

add eventlet to timeout long running request#34
abemassry wants to merge 1 commit into
jahschwa:masterfrom
abemassry:timeout-link_echo

Conversation

@abemassry

Copy link
Copy Markdown

attempts to fix #11

@jahschwa

jahschwa commented Nov 1, 2017

Copy link
Copy Markdown
Owner

I don't know why yet, but importing eventlet appears to break protocols other than the CLI (tested with xmpp and socket so far). They just hang when connecting, but perhaps more specifically when spawning a new thread? Maybe it changes threading behavior somehow? Will look further today or tomorrow.

@jahschwa

jahschwa commented Nov 1, 2017

Copy link
Copy Markdown
Owner

Seems related to any of these, especially the first one:
https://bugs.python.org/issue13697
http://eventlet.net/doc/patching.html#monkeypatching-the-standard-library
eventlet/eventlet#249

I'm not yet convinced those fully explain this specific issue, but it's possible this wouldn't be usable until I finally get around to switching to python3. Currently very confused as to why CLI isn't affected even though it uses threading as well; red herring?

For what it's worth, xmpp gets stuck here:
https://github.com/TheSchwa/sibyl/blob/master/protocols/sibyl_xmpp.py#L243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

link_echo needs a request timeout

2 participants