Delete saved creds on auth failure and rename creds var#68
Open
jfrederickson wants to merge 1 commit into
Open
Delete saved creds on auth failure and rename creds var#68jfrederickson wants to merge 1 commit into
jfrederickson wants to merge 1 commit into
Conversation
In the event an access token is revoked, we might still have user/pass credentials that are valid. If we receive a 401 or 403, we can be reasonably sure that the credentials in the bot's state are invalid, so let's just clear them out. Sibyl will still disable the Matrix protocol if this happens, requiring a restart; this just ensures that you won't have to dig around in/delete the pickled state to get back up and running.
jahschwa
requested changes
May 19, 2019
jahschwa
left a comment
jahschwa
left a comment
Owner
There was a problem hiding this comment.
Thought about this a bit, is there a case we wouldn't want to immediately try again with username/password if the token fails? "If we have a token, try to connect with the token, catch MatrixRequestError[401, 403] and set token to None, try to connect with password" and "We don't have a token, try to connect with password"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event an access token is revoked, we might still have user/pass
credentials that are valid. If we receive a 401 or 403, we can be
reasonably sure that the credentials in the bot's state are invalid,
so let's just clear them out.
Sibyl will still disable the Matrix protocol if this happens,
requiring a restart; this just ensures that you won't have to dig
around in/delete the pickled state to get back up and running.