Repository navigation
Finalize CRAN comments and release checks for 0.2.2 - #252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only update matches the verified evidence and leaves the checked package artifact unchanged.
No open issues 🎉
What changed in this PR
Finalizes the CRAN submission comments for bifrost 0.2.2 without changing package source.
Changes:
- Updates links to passing post-merge CI checks.
- Identifies the checked source archive and retains its checksum.
- Removes stale preparation instructions and troubleshooting details while preserving known limitations.
| File | Description |
|---|---|
| cran-comments.md | Finalizes submission evidence and archive instructions. |
Review effort: Balanced
18 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalize the CRAN submission comments and spelling dictionary, keep the RNG test within CRAN's two-core limit, and remove the Windows temporary-file NOTE.
The RNG test still compares two and three real Future chunks, scheduled on at most two workers, and asserts identical results and final caller RNG state. The Windows NOTE came from the separate test that deliberately kills a background worker: forced termination bypasses Rscript's normal temporary-file cleanup. That test now gives its workers a test-owned temporary directory with scoped cleanup. It retains real cancellation and all eight existing assertions.
No production fitting or RNG code changed. No tests, warnings, coverage requirements, or check stages were disabled. Temporary diagnostic instrumentation was removed.
Validation
Rscript…files; cooperative shutdown leaves none (log). After the fix, the full Windows check reports Status: OK, including the detritus check (log).87b6d31444424a90f823aebcbcbd291bbf80b5d6, checked 2026-10-17 UTC.R CMD check --as-cran --run-donttest, including PDF and HTML manuals: 0 errors, 0 warnings, 1 NOTE (unable to verify current time). 2,980 passes, zero test failures/warnings, 138 expected skips. The 101-page PDF passedqpdf --check.4a817a3ab4e3f6c98efc01342ebaf8fb0b47b61287a05294d943c596a78a00dc.git diff --checkpassed. The subsequent notes commit changes only files excluded from source packages.Final head
310f14f8b99a8576ff2d079c251cf867355c1827: all CI checks passed. All five R CMD check jobs passed, including Windows with Status: OK; both parallel smoke jobs, pkgdown build, advisory audit, and Codecov patch check passed. Documentation deployment was correctly skipped for the PR. Whole-package coverage is exactly 100% with zero uncovered rows (strict gate passed); its test run recorded 4,958 assertions, zero warnings/failures, and 43 expected skips. Required reviewer approval remains outstanding.Latest evidence and checklist: tools/releases/0.2.2.md. Local archive, logs and manual: output/release-0.2.2-pr252-check/run-yr9i7roc/. Windows diagnostic and targeted regression logs: output/windows-temp-investigation/. Earlier outputs are preserved; their source archives are superseded.
Issue #231 remains deferred. Local outputs and installations are preserved. No merge, CRAN submission, tag, or GitHub release has been performed.