Skip to content

ci: align commit-check + add license, pre-commit hooks#30

Merged
jal-co merged 2 commits into
mainfrom
docs/add-license
May 31, 2026
Merged

ci: align commit-check + add license, pre-commit hooks#30
jal-co merged 2 commits into
mainfrom
docs/add-license

Conversation

@jal-co

@jal-co jal-co commented May 31, 2026

Copy link
Copy Markdown
Owner

What

Repo conventions + meta fixes:

  1. LICENSE — adds the missing MIT file (Copyright (c) 2026 Justin Levine).
  2. .github/cchk.toml — commit-check policy allowing every branch/commit type the project documents.
  3. .pre-commit-config.yaml — local hooks running the same commit-check validation as CI, plus CONTRIBUTING setup docs.

Why

LICENSE: package.json declared MIT and the README badge linked to ./LICENSE, but the file was never committed — so GitHub showed no license and the badge link was broken.

commit-check config: This PR's first CI run failed the branch check. commit-check ran with no config, so its defaults only allowed feat/fix/chore — rejecting docs/, refactor/, perf/, style/, test/, ci/, build/ even though CONTRIBUTING.md and labeler.yml document them. cchk.toml aligns the tool with the project's own conventions (Conventional Commits 1.0.0 + Conventional Branch).

pre-commit: Contributors now get the same branch + commit-message checks locally (before pushing) that CI enforces, sharing the same cchk.toml policy.

Closes #

Type

  • docs — Documentation
  • ci — CI/CD changes

How

  • LICENSE: exact SPDX MIT text → GitHub detector shows the MIT badge.
  • cchk.toml: allow_branch_types / allow_commit_types set to the documented set; bot authors ignored. Verified with the commit-check CLI — valid types pass, bogus types fail (config is read, not bypassed).
  • .pre-commit-config.yaml: pins commit-check v2.7.0, check-message (commit-msg) + check-branch (pre-push). Documented one-time setup in CONTRIBUTING.

Testing

  • commit-check --branch / --message — pass locally
  • npm run lint (tsc --noEmit) — passes
  • npm test — 62/62 pass
  • No application code changed.

Screenshots

N/A — repository metadata / CI config.

The package.json declared MIT and the README linked a license badge to
./LICENSE, but the LICENSE file itself was never committed. GitHub
detects licenses from the file, not package.json, so the repo showed no
license. Adds the standard MIT text.
@vercel

vercel Bot commented May 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
scn-stack Ready Ready Preview, Comment May 31, 2026 1:48am

Request Review

commit-check ran with no config, so its built-in defaults only allowed
feat/fix/chore branch prefixes. This rejected docs/, refactor/, perf/,
style/, test/, ci/, and build/ branches even though CONTRIBUTING.md and
labeler.yml document them as valid. Adds .github/cchk.toml allowing the
full documented set for both branches and commit messages.
@github-actions github-actions Bot added the ci CI/CD and workflow changes label May 31, 2026
@jal-co jal-co changed the title docs: add MIT license file docs: add MIT license + fix commit-check branch types May 31, 2026
@jal-co jal-co merged commit c1e65c2 into main May 31, 2026
5 checks passed
@jal-co jal-co changed the title docs: add MIT license + fix commit-check branch types ci: align commit-check + add license, pre-commit hooks May 31, 2026
jal-co added a commit that referenced this pull request May 31, 2026
* ci: add pre-commit hooks for commit-check

Adds a pre-commit config running the same commit-check validation as
CI (Conventional Commit messages, Conventional Branch names), so
contributors catch issues before pushing instead of on the PR. Hooks
share the .github/cchk.toml policy with CI. Documents the one-time
setup in CONTRIBUTING.

This change was authored alongside #30 but landed after that PR was
merged, so it never made it onto main.

* docs: sync CONTRIBUTING with global versioning conventions

Adds a Versioning section documenting Semantic Versioning 2.0.0 and the
feat->MINOR / fix->PATCH / breaking->MAJOR mapping, matching the new
global AGENTS.md conventions. Notes the 0.y.z initial-development
status, tag/release rules, and the automated publish-on-release flow.
Also clarifies that breaking changes may use the BREAKING CHANGE footer
in addition to the ! marker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD and workflow changes docs Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant