Bump retries, add backoff/jitter, fully reopen TreeFS on retry#131
Merged
Conversation
Three attempts is not enough under sustained contention — the race can win the CAS check between Refresh and Commit on every attempt even when Refresh correctly observes the new ref. Bump retries to 12 and add exponential backoff with full jitter so colliding writers desynchronize. Also: rather than just Refresh (which reuses the same go-git Repository handle), fully reopen the TreeFS between attempts. Adds Repo.Reopen and Store.ReopenFS via a new Reopener interface. Defense in depth against any cached go-git state (packed-refs cache etc.) that Refresh might miss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three attempts is not enough under sustained contention — the race can win the CAS check between Refresh and Commit on every attempt even when Refresh correctly observes the new ref. Bump retries to 12 and add exponential backoff with full jitter so colliding writers desynchronize.
Also: rather than just Refresh (which reuses the same go-git Repository handle), fully reopen the TreeFS between attempts. Adds Repo.Reopen and Store.ReopenFS via a new Reopener interface. Defense in depth against any cached go-git state (packed-refs cache etc.) that Refresh might miss.