feat(props): friendly colour words and when/active_when presets - #21
Merged
Merged
Conversation
Colour props (_color, _active_color, per-slot overrides, raw channel pins, window/pane accents) now accept a theme role word (accent, notice, ...) or a palette word (peach, mauve, surface_0, ...) resolved through @thm_role_<w> then @thm_<w> — the theme wins over tmux native names, so red is the palette red. Raw tmux values (hex, colour255, formats) pass through untouched. Visibility and escalation conditions gain two presets: always and never (alias off), normalized in shared render_style.sh helpers and consumed by layout.sh (powerline splice + group visibility), module_render.sh (the standalone-pill gate and chan's active switch). Everything else passes through raw — a bare unknown word was already false (tmux reads it as a format variable), the presets make the two useful constants sayable. git.conf and gitmux.conf set their in-repo when gate with -ogq (was -gq, which clobbered any user value at source time), matching zoom.conf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accent,info,notice,muted,alert,error) or a palette word (peach,mauve,surface_0, ...), resolved through@thm_role_<w>then@thm_<w>; the theme wins over tmux native colour names (red= palette red). Raw tmux values — hex,colour255,#{E:...}refs, draw-time conditionals — pass through untouched.@themux_<name>_when/_active_whengainalways/never(aliasoff) presets; bare format variables (window_zoomed_flag,client_prefix) and raw#{...}/#(...)conditions keep working verbatim.whengate withset -gq, clobbering any user value at source time — now-ogq, matching zoom.Replaces #19 (closed by the base-branch delete when #18 merged; rebased onto main).
Changes
utils/render_style.shthemux_colour,themux_when_cond,themux_active_condutils/module_render.shactive_when, and the standalone-pillwhengateutils/layout.shwhenat the powerline splice and group visibilityutils/window_render.sh,utils/pane_render.shthemux_colourmodules/git.conf,modules/gitmux.confwhengate-gq→-ogq(user-overridable)tests/prop_grammar.sh+ expected,run_tests.shdocs/reference/configuration.md,status-line.mdTest plan
./run_tests.sh— 18/18 green (newprop_grammarsuite included)shellcheckon all touched scripts🤖 Generated with Claude Code