feat: add network access toggle to server settings#133
Open
rayl15 wants to merge 1 commit intojamiepine:mainfrom
Open
feat: add network access toggle to server settings#133rayl15 wants to merge 1 commit intojamiepine:mainfrom
rayl15 wants to merge 1 commit intojamiepine:mainfrom
Conversation
Exposes the existing remote server mode through a checkbox in Server Connection settings. When enabled, the server binds to 0.0.0.0 instead of 127.0.0.1, making it accessible from other devices on the network. The plumbing already existed (Rust sidecar passes --host 0.0.0.0 when remote=true, serverStore has mode state, Python backend accepts --host), but the UI hardcoded startServer(false). This wires it up. Closes jamiepine#104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.0.0.0instead of127.0.0.1, making it accessible from other devices on the networkDetails
The plumbing for this already existed:
main.rs): passes--host 0.0.0.0whenremote=trueserverStore.ts): hasmode: 'local' | 'remote'with persistenceserver.py): accepts--hostCLI arglifecycle.ts):startServer(remote)accepts booleanBut
App.tsxhardcodedstartServer(false), and no UI exposed the toggle. This PR wires it up:App.tsx— reads persistedmodefrom store on startup and passesmode === 'remote'tostartServer()ConnectionForm.tsx— adds a checkbox that togglesmodebetween'local'and'remote', with a toast indicating restart is requiredOnly shown in Tauri (desktop) mode, not in web.
Closes #104
Test plan
--host 0.0.0.0binds to all interfaces (TCP *:17493)--host 127.0.0.1only accessible on localhost0.0.0.0