Repository navigation
fix(ci): downstream-typecheck — uv venv has no pip, use uv pip install - #7
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCI workflow downstream type checking step updated to use ChangesCI Workflow Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Summary
CI's
downstream-typecheckjob has been failing on every push since PR #4 (which added the job). The repo was about to flip to public with red CI on main — this fixes it.What broke
uv venvcreates a minimal venv without pip. The next line then calls/tmp/downstream-venv/bin/pipwhich doesn't exist, exiting 127.Failure log on
4785bc1(PR #5 merge):Same failure on
510cb70(PR #6 merge) — confirmed minutes ago.Fix
Use
uv pip install --python /tmp/downstream-venv/bin/python ...— uv's pip-compatible installer works against any venv directly, no pip-in-venv needed.Verified locally
Impact
CI has been red on
mainsince PR #4 merged (about 3 hours ago). Blocking the v0.1.0 GA release sequence. Once this lands, the next CI run onmainshould go green and the repo can flip to public + tag v0.1.0.Test plan
uv pip install --python--stricton a stub importing all 22 public re-exports succeedsSummary by CodeRabbit