Skip to content

fix(ci): downstream-typecheck — uv venv has no pip, use uv pip install - #7

Merged
sunilp merged 1 commit into
mainfrom
chore/fix-downstream-typecheck
May 6, 2026
Merged

sunilp merged 1 commit into
mainfrom
chore/fix-downstream-typecheck

Conversation

@sunilp

@sunilp sunilp commented May 6, 2026 •

Copy link
Copy Markdown
Member

Summary

CI's downstream-typecheck job has been failing on every push since PR #4 (which added the job). The repo was about to flip to public with red CI on main — this fixes it.

What broke

- name: Install wheel in fresh venv
  run: |
    uv venv /tmp/downstream-venv
    /tmp/downstream-venv/bin/pip install dist/*.whl mypy

uv venv creates a minimal venv without pip. The next line then calls /tmp/downstream-venv/bin/pip which doesn't exist, exiting 127.

Failure log on 4785bc1 (PR #5 merge):

/home/runner/work/_temp/...sh: line 2: /tmp/downstream-venv/bin/pip: No such file or directory
Process completed with exit code 127.

Same failure on 510cb70 (PR #6 merge) — confirmed minutes ago.

Fix

Use uv pip install --python /tmp/downstream-venv/bin/python ... — uv's pip-compatible installer works against any venv directly, no pip-in-venv needed.

Verified locally

$ uv build --wheel                 # produces dist/jamjet_engram-0.1.0-py3-none-any.whl
$ uv venv /tmp/v                   # minimal venv, no pip
$ uv pip install --python /tmp/v/bin/python dist/jamjet_engram-0.1.0-py3-none-any.whl mypy
$ /tmp/v/bin/mypy --strict /tmp/stub.py
Success: no issues found in 1 source file

Impact

CI has been red on main since PR #4 merged (about 3 hours ago). Blocking the v0.1.0 GA release sequence. Once this lands, the next CI run on main should go green and the repo can flip to public + tag v0.1.0.

Test plan

  • yaml syntactically valid
  • Wheel builds, installs cleanly in a uv-managed venv via uv pip install --python
  • mypy --strict on a stub importing all 22 public re-exports succeeds
  • CI on this PR goes green (the actual proof)

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration to use an alternative package installer for improved dependency management during type checking.

@coderabbitai

coderabbitai Bot commented May 6, 2026 •

Copy link
Copy Markdown
ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: a076fec6-2d69-44ad-a61d-f7d7568ffccc

📥 Commits

Reviewing files that changed from the base of the PR and between 510cb70 and 0c575ae.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

CI workflow downstream type checking step updated to use uv's pip installer instead of the venv's direct pip path. Python executable location explicitly specified via --python flag. Explanatory comments added to clarify the new installation approach.

Changes

CI Workflow Configuration

Layer / File(s) Summary
Installation Command Update
.github/workflows/ci.yml
Pip installation method changed from venv's direct pip path to uv pip with explicit --python flag pointing to the venv's Python binary in the downstream type checking step (lines 70–76).
Documentation
.github/workflows/ci.yml
Explanatory comments added to clarify the new uv-based pip installation approach.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A workflow tweak, so clean and small,
Using uv pip, we answer the call,
Comments guide us through the way,
CI whispers—all's well today!


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sunilp
sunilp merged commit ccba890 into main May 6, 2026
4 checks passed
@sunilp
sunilp deleted the chore/fix-downstream-typecheck branch May 6, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant