Repository navigation
Correct coordinates and capability claims in READMEs - #15
Merged
Merged
Conversation
The root README used a SNAPSHOT version and an artifact id that was never published. It also described H2, Postgres and SQLite backends and restart recovery that the starter and server do not provide. Align both with what 0.4.0 ships.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The example poms depended on 0.1.0-SNAPSHOT and on versions that were never published (starter 0.1.0, autoconfigure 0.1.2). crash-recovery, latency-comparison, real-agent and new-way now compile against Central.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects README claims that do not match the 0.4.0 code. Each item with its evidence:
jamjet-spring-boot-starter:0.1.0-SNAPSHOTjamjet-runtime-spring-boot-starter(jamjet-spring-boot-starter/pom.xml). Maven Central metadata lists 0.1.1, 0.2.0, 0.3.1, 0.4.0 for it and only 0.1.0 for the old name. Nowdev.jamjet:jamjet-runtime-spring-boot-starter:0.4.0.jamjet-runtime-instrument:0.1.0-SNAPSHOTJamjetAutoConfiguration.stateBackendaccepts onlyin-memoryand warns and falls back otherwise.JamjetServer.createBackendthrows on anything else.JdbcStateBackendexists in core (H2/PostgreSQL per its javadoc) but neither the starter nor the server uses it. No SQLite code exists.DurabilityContextis a thread-local with an in-memoryLinkedHashMap. The crash-recovery example writes its own checkpoint file. README now says so.WorkerPooluses a virtual-thread-per-task executor.jamjet-agentandjamjet-agent-spring-boot-starterexamples/spring-boot-comparisondependency rowExample poms (second commit): crash-recovery, latency-comparison and real-agent moved from
0.1.0-SNAPSHOTto 0.4.0. spring-boot-comparison/new-way moved from starter 0.1.0 (not on Central) to 0.4.0. Each of these four compiles against Central with a clean local repo (mvn compile). spring-boot-comparison/old-way pinnedjamjet-spring-boot-autoconfigure:0.1.2, which does not exist on Central (only 0.1.0 does); it now pins 0.1.0, but it still does not compile because its code calls a sidecar client API that 0.1.0 does not have. It is a reference-only project and I left the code as is.Module READMEs checked:
jamjet-agent-spring-boot-starter(0.4.0, no issues), other examples have no coordinate or backend claims beyond the one fixed. Note: several examplepom.xmlfiles still pin0.1.0-SNAPSHOT; not changed here since this PR is README-only.No CI workflow runs on docs-only changes if path filters apply; status noted below once checked.
🤖 Generated with Claude Code