Skip to content

Fix API spec to match actual response types#9

Merged
acallaghan merged 2 commits intomainfrom
claude/fix-merge-conflict-nAXza
Mar 29, 2026
Merged

Fix API spec to match actual response types#9
acallaghan merged 2 commits intomainfrom
claude/fix-merge-conflict-nAXza

Conversation

@acallaghan
Copy link
Copy Markdown
Contributor

@acallaghan acallaghan commented Mar 29, 2026

Summary

Replays the schema fixes from PR #6 cleanly onto main, resolving the merge conflicts caused by intervening Postman collection and studio.json changes.

  • room.id: Changed from string to integer — the API returns numeric IDs
  • customer.regular_bookings_count: Can return boolean false instead of 0 — updated to oneOf [integer, boolean]
  • short_group: Added number (nullable) and booking_count fields for customer band responses
  • dashboard_booking: Rewritten to match actual dashboard response format — uses start/end datetimes, split room code, formatted amount_due string, payments_recieved boolean, extras_summary as array, and adds link/type/class fields

Supersedes #6 (closed due to merge conflicts).

Test plan

  • YAML validates (python3 -c "import yaml; yaml.safe_load(open('v2/jammed.yaml'))")
  • Verify GET /dashboard response matches updated dashboard_booking schema
  • Verify room.id is integer in staging
  • Verify regular_bookings_count handles boolean false

https://claude.ai/code/session_01DgxWeWcLq3ao4NDvAUQTzX


Note

Low Risk
Low risk: spec-only updates that adjust documented response types/fields; main risk is client generation changes if consumers rely on the previous (incorrect) schemas.

Overview
Aligns v2/jammed.yaml schemas with actual API responses by correcting type mismatches and expanding models where the API returns different shapes.

Notable updates include room.id switching to integer, customer.regular_bookings_count allowing boolean false, adding number (nullable) and booking_count to short_group for customer band responses, and a rewrite of the dashboard_booking schema to match the dashboard payload (e.g., start/end datetime strings, formatted amount_due, extras_summary array, and additional link/type/class fields).

Written by Cursor Bugbot for commit bb52899. This will update automatically on new commits. Configure here.

claude and others added 2 commits March 29, 2026 15:10
Replays schema fixes from PR #6 cleanly onto main, avoiding merge
conflicts caused by intervening Postman collection and studio.json changes.

- room.id: string → integer (API returns numeric IDs)
- customer.regular_bookings_count: allow boolean false in addition to integer
- short_group: add number (nullable) and booking_count fields
- dashboard_booking: rewrite to match actual dashboard response format
  (start/end datetimes, split room code, formatted amount_due, etc.)

https://claude.ai/code/session_01DgxWeWcLq3ao4NDvAUQTzX
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 29, 2026

Deploying api with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb52899
Status: ✅  Deploy successful!
Preview URL: https://0ece1613.api-dwa.pages.dev
Branch Preview URL: https://claude-fix-merge-conflict-na.api-dwa.pages.dev

View logs

@acallaghan acallaghan merged commit 3c56a89 into main Mar 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants