Fix API spec to match actual response types#9
Merged
acallaghan merged 2 commits intomainfrom Mar 29, 2026
Merged
Conversation
Replays schema fixes from PR #6 cleanly onto main, avoiding merge conflicts caused by intervening Postman collection and studio.json changes. - room.id: string → integer (API returns numeric IDs) - customer.regular_bookings_count: allow boolean false in addition to integer - short_group: add number (nullable) and booking_count fields - dashboard_booking: rewrite to match actual dashboard response format (start/end datetimes, split room code, formatted amount_due, etc.) https://claude.ai/code/session_01DgxWeWcLq3ao4NDvAUQTzX
Deploying api with
|
| Latest commit: |
bb52899
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ece1613.api-dwa.pages.dev |
| Branch Preview URL: | https://claude-fix-merge-conflict-na.api-dwa.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replays the schema fixes from PR #6 cleanly onto main, resolving the merge conflicts caused by intervening Postman collection and studio.json changes.
room.id: Changed fromstringtointeger— the API returns numeric IDscustomer.regular_bookings_count: Can return booleanfalseinstead of0— updated tooneOf [integer, boolean]short_group: Addednumber(nullable) andbooking_countfields for customer band responsesdashboard_booking: Rewritten to match actual dashboard response format — usesstart/enddatetimes,splitroom code, formattedamount_duestring,payments_recievedboolean,extras_summaryas array, and addslink/type/classfieldsSupersedes #6 (closed due to merge conflicts).
Test plan
python3 -c "import yaml; yaml.safe_load(open('v2/jammed.yaml'))")GET /dashboardresponse matches updateddashboard_bookingschemaroom.idis integer in stagingregular_bookings_counthandles booleanfalsehttps://claude.ai/code/session_01DgxWeWcLq3ao4NDvAUQTzX
Note
Low Risk
Low risk: spec-only updates that adjust documented response types/fields; main risk is client generation changes if consumers rely on the previous (incorrect) schemas.
Overview
Aligns
v2/jammed.yamlschemas with actual API responses by correcting type mismatches and expanding models where the API returns different shapes.Notable updates include
room.idswitching tointeger,customer.regular_bookings_countallowingbooleanfalse, addingnumber(nullable) andbooking_counttoshort_groupfor customer band responses, and a rewrite of thedashboard_bookingschema to match the dashboard payload (e.g.,start/enddatetime strings, formattedamount_due,extras_summaryarray, and additionallink/type/classfields).Written by Cursor Bugbot for commit bb52899. This will update automatically on new commits. Configure here.