Remove unused sMidiCtlChar#3717
Merged
softins merged 1 commit intoMay 29, 2026
Merged
Conversation
This became unused in PR jamulussoftware#3502 MIDI update, but was not removed. Some compilers, notably clang++ on Mac, emit a warning because it is unused.
pljones
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Removes the unused array
sMidiCtlCharfromsrc/sound/soundbase.cppCHANGELOG: Internal: Removed unused array to silence compiler warning.
Context: Fixes an issue?
This became unused in PR #3502 MIDI update, but was not removed at the time. Some compilers, notably clang++ on Mac, emit a warning because it is unused.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Nothing. Trivial change, and compiles correctly.
Checklist