GSM metrics more responsive - #323
Open
rslater-cs wants to merge 2 commits into
Open
rslater-cs wants to merge 2 commits into
rslater-cs wants to merge 2 commits into
Conversation
…timeout; exposed modem driver endpoint to trigger full info emit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
A regression that appeared during redesign was that GSM went from listnening to the modem driver for info and repeating it in an event driven fashion to polling the driver for info, this was done to simplify modem info sources which are event driven and polling driven but it has resulted in some high frequency information, such as signals, to only be reported every 1-2 minutes (when it should be every 5-10 seconds). I have changed the GSM service back to using a more event driven route.
Manual test
Manual test description
Run the code on a box and check that the signals on the UI are updating every 10 seconds
Added tests?
Added to documentation?