Skip to content

refactor(ui): replace Button render prop with native links#129

Merged
janhesters merged 1 commit intomainfrom
refactor/button-render-to-link-and-tabler-icons
Feb 25, 2026
Merged

refactor(ui): replace Button render prop with native links#129
janhesters merged 1 commit intomainfrom
refactor/button-render-to-link-and-tabler-icons

Conversation

@janhesters
Copy link
Copy Markdown
Owner

Summary

  • Replace <Button render={<Link>}> / <Button render={<a>}> pattern with native <Link> and <a> elements styled via buttonVariants() across 15 files for proper semantic HTML
  • Migrate remaining react-icons/tb icon imports (TbArrowLeft, TbBrightness, TbChevronLeft, etc.) to @tabler/icons-react equivalents
  • Fix avatar styling on onboarding pages (add after:rounded-lg and object-cover)

Test plan

  • Verify all links render correctly and navigate to the expected routes
  • Verify button styling (size, variant, custom classes) is preserved on all converted links
  • Verify icons render correctly after the migration
  • Verify avatar images display properly on onboarding pages

Replace Button render prop pattern with native Link/anchor
elements styled via buttonVariants(). Migrate react-icons/tb
to @tabler/icons-react. Fix avatar styling on onboarding.
@janhesters janhesters force-pushed the refactor/button-render-to-link-and-tabler-icons branch from 09ec865 to 1ae7cb7 Compare February 25, 2026 20:16
@janhesters janhesters merged commit 141d74f into main Feb 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant