Repository navigation
Parameterize build-local.sh registry/server/path via env vars - #5
Open
johnnyxmas wants to merge 1 commit into
Open
johnnyxmas wants to merge 1 commit into
johnnyxmas wants to merge 1 commit into
Conversation
REGISTRY, SERVER, SERVICE, and the SSH deploy target (user + path) were hardcoded directly as shell variables, meaning anyone besides the original maintainer had to edit four separate values before the script would work in their own environment. Move each to an env var with the current value as the default, so the script keeps working unchanged for the existing deployment while becoming usable elsewhere via e.g.: READARR_BUILD_REGISTRY=myregistry:5000 READARR_DEPLOY_SERVER=nas.local READARR_DEPLOY_USER=admin READARR_DEPLOY_PATH=/volume1/docker/readarr ./build-local.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4.
REGISTRY,SERVER,SERVICE, and the SSH deploy target (user + path) were hardcoded directly as shell variables, so anyone besides the original deployment had to edit four separate values in the script before it would run at all in their own environment.Change
Each value now reads from an env var, falling back to the current hardcoded value as the default -- so this is a no-op for the existing deployment (running
./build-local.shwith no env vars set produces byte-identical behavior), while making the script usable elsewhere via e.g.:Test plan