Skip to content

Add eslint to normalize code style#10

Open
XatMassacrE wants to merge 1 commit into
janhuenermann:masterfrom
XatMassacrE:master
Open

Add eslint to normalize code style#10
XatMassacrE wants to merge 1 commit into
janhuenermann:masterfrom
XatMassacrE:master

Conversation

@XatMassacrE
Copy link
Copy Markdown

Maybe it's not a problem for one person, but i think a uniform code style is important for collaborating.
So i add airbnb to normalize code, but i find warnings and errors are too much that i finally comment it.
But i reserve the basic config so you can custom your own code style.
By the way, webpack 2 replace loaders with rules, and i fix it.

@janhuenermann
Copy link
Copy Markdown
Owner

Thanks, this is great! Def need some kind of uniform code style, agree! But I don't have any experience with eslint or airbnb. Let me read about these tools first, before changing the code base/code style.

@andrewgremlich
Copy link
Copy Markdown

@janhuenermann you could definitely set the contribution criteria seeing as you started the repo.

Have you figured out eslint yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants