Add eslint to normalize code style#10
Open
XatMassacrE wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks, this is great! Def need some kind of uniform code style, agree! But I don't have any experience with eslint or airbnb. Let me read about these tools first, before changing the code base/code style. |
|
@janhuenermann you could definitely set the contribution criteria seeing as you started the repo. Have you figured out eslint yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe it's not a problem for one person, but i think a uniform code style is important for collaborating.
So i add airbnb to normalize code, but i find warnings and errors are too much that i finally comment it.
But i reserve the basic config so you can custom your own code style.
By the way, webpack 2 replace loaders with rules, and i fix it.