Skip to content

Conversation

@palant
Copy link

@palant palant commented Jul 2, 2012

There is a bunch of unrelated minor changes here: fixed various JavaScript strict warnings (in at least one case the warning actually indicated a bug), added a Python script for use with Extension Auto-Installer (yes, yet another build environment), fixed Roots tab being permanent (inconsistent). The main change here is a different table view based on SlickGrid however. Why I did this:

  • No pagination necessary: SlickGrid will display even large lists efficiently - the entries are only rendered when required.
  • Better performance: even displaying 500 entries per page caused a noticeable delay.
  • Better display of owners and edges: the edge name and target are actually displayed inline without having to expand anything (tooltip will display more information). The number of edges/owners links to the details page where full information is available.
  • Fixed row height: If something doesn't fit in then it is cut off, rest of the text is visible in the tooltip. A single row with masses of content doesn't make scrolling hard.
  • Column resizing/reordering and potentially also sorting/filtering: these features are built into SlickGrid and don't require any code whatsoever.

The implementation is somewhat hacky, I also didn't bother removing code that is no longer used. The grid doesn't adapt to the window being resized (shouldn't be hard to change). Most importantly however, the changes aren't complete: the Details view needs to be improved next. I think that it should be possible to open multiple Details tabs, one for each object. Tab title should be something like "Details (0x12345678)" then. And it also needs to present the information better: the regular fields should be followed by two table views displaying edges and owners. So you will see all the edges and owners at one glance.

I would like to get your feedback on these changes before I proceed.

@yfdyh000
Copy link

Hi palant, thank you for creating the changes. For this version, my experience is as follows:

  • A new interface, fixed no vertical scrollbar issue, and remove useless index column and "get remaining" button, nice works. But the new colors is a little too harsh.
  • These entrys seem no longer have sub-menu, the small triangle button does not to work, how to retrieve it.

Requests:

  • I want a convenient comparison function to identify various differences for identifying memory leaks, like new/changed/removed or bigger/many/... filter.
  • "Roots" (and other tabs) should be removed or updated after dump a new analysis.

@janodvarko, can you review and reply the pull req?
Otherwise, @palant, can you interest to continue development and release a fork?
Thanks to all.

@janodvarko
Copy link
Owner

Ah, I totally missed the pull, I'll take a look at that ASAP

@palant Thanks for the patch!

Honza

@yfdyh000
Copy link

A correct, I can see the submenu in Home (and others) tab, just does not in Roots (and Path) tab.

@yfdyh000
Copy link

yfdyh000 commented Apr 6, 2015

@janodvarko Any news?

@janodvarko
Copy link
Owner

The fixes in the patch looks good. I am just worried that the patch needs more work before being applied (or split into more patches)

The implementation is somewhat hacky, I also didn't bother removing code that is no longer used. The grid doesn't adapt to the window being resized (shouldn't be hard to change). Most importantly however, the changes aren't complete: the Details view needs to be improved next. I think that it should be possible to open multiple Details tabs, one for each object. Tab title should be something like "Details (0x12345678)" then. And it also needs to present the information better: the regular fields should be followed by two table views displaying edges and owners. So you will see all the edges and owners at one glance.

I don't know if @palant is still interested in finishing this (give how long time ago this has been done, my fault I know).

In any case, my feedback is positive and it would be great to have this done and merged.

@palant ?

Cheers,
Honza

@palant
Copy link
Author

palant commented Apr 6, 2015

Frankly, I've given up on ccdump a long time ago 😞. Never managed to get the performance I needed, so rather writing custom scripts to analyze dumps when I need to. Sorry - no, I'm no longer interested in spending time on this.

@janodvarko
Copy link
Owner

I see, no problem, thanks for the reply!
I am not going to merge the patch at this point.

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants