Skip to content

chore: move Scoop distribution to the official Extras bucket#247

Open
janosmiko wants to merge 2 commits into
mainfrom
chore/scoop-extras-migration
Open

chore: move Scoop distribution to the official Extras bucket#247
janosmiko wants to merge 2 commits into
mainfrom
chore/scoop-extras-migration

Conversation

@janosmiko

@janosmiko janosmiko commented May 18, 2026

Copy link
Copy Markdown
Owner

Summary

Retires the custom janosmiko/scoop-bucket in favor of the official ScoopInstaller/Extras bucket (issue #222).

  • Removes the GoReleaser scoops: block — Scoop is no longer published from this repo.
  • docs/installation.md and README.md point users at scoop bucket add extras.
  • docs/release-process.md drops Scoop from the GoReleaser-driven tables.

The Extras manifest (with env_set for the LFK_*_DIR variables, so Scoop installs persist data across updates) is submitted separately to ScoopInstaller/Extras.

Do not merge until the ScoopInstaller/Extras PR is merged — otherwise installation.md documents an install path that does not work yet.

Test plan

  • goreleaser check passes (config valid after removing the scoops: block)
  • CI green
  • Merge only after the Extras manifest PR is live

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 048787be-ab1a-408d-9103-79c4d5ad33b5

📥 Commits

Reviewing files that changed from the base of the PR and between 660502d and 24860d8.

📒 Files selected for processing (4)
  • .goreleaser.yaml
  • README.md
  • docs/installation.md
  • docs/release-process.md
💤 Files with no reviewable changes (1)
  • .goreleaser.yaml
✅ Files skipped from review due to trivial changes (1)
  • docs/release-process.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

Summary by CodeRabbit

  • Documentation

    • Updated Windows install instructions to use the Scoop "extras" bucket.
    • Revised release process steps related to Scoop manifests and post-release validation.
  • Chores

    • Stopped publishing releases to Scoop; other publishing channels remain configured.
    • Updated release tooling configuration to reflect these changes.

Walkthrough

This PR removes the scoops publisher from .goreleaser.yaml, updates Windows/Scoop installation instructions to add the extras bucket instead of the janosmiko bucket, and revises release-process documentation to reference ScoopInstaller/Extras, separate Homebrew secrets, update the GoReleaser skip list, and document the excavator bot's manifest auto-updates.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: migrating Scoop distribution from a custom bucket to the official Extras bucket.
Description check ✅ Passed The description is complete and well-structured, covering summary, type of change (chore), changes made, testing performed, and important merge conditions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 152: Replace the brittle one-liner "scoop bucket add extras && scoop
install lfk" with a tolerant sequence that ignores the "bucket already exists"
error and always runs the install; specifically, wrap or append error
suppression around the bucket-add step for the commands "scoop bucket add
extras" and "scoop install lfk" (e.g., suppress stderr or use a try/catch so the
add step failing because the bucket exists does not prevent running scoop
install lfk).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eb6f2ad3-c6de-4af5-92ab-1e615ecf6eef

📥 Commits

Reviewing files that changed from the base of the PR and between 659c0bd and 8983890.

📒 Files selected for processing (4)
  • .goreleaser.yaml
  • README.md
  • docs/installation.md
  • docs/release-process.md
💤 Files with no reviewable changes (1)
  • .goreleaser.yaml

Comment thread README.md Outdated
@janosmiko janosmiko force-pushed the chore/scoop-extras-migration branch from 660502d to 24860d8 Compare May 31, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant