chore: move Scoop distribution to the official Extras bucket#247
chore: move Scoop distribution to the official Extras bucket#247janosmiko wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThis PR removes the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 152: Replace the brittle one-liner "scoop bucket add extras && scoop
install lfk" with a tolerant sequence that ignores the "bucket already exists"
error and always runs the install; specifically, wrap or append error
suppression around the bucket-add step for the commands "scoop bucket add
extras" and "scoop install lfk" (e.g., suppress stderr or use a try/catch so the
add step failing because the bucket exists does not prevent running scoop
install lfk).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: eb6f2ad3-c6de-4af5-92ab-1e615ecf6eef
📒 Files selected for processing (4)
.goreleaser.yamlREADME.mddocs/installation.mddocs/release-process.md
💤 Files with no reviewable changes (1)
- .goreleaser.yaml
660502d to
24860d8
Compare
Summary
Retires the custom
janosmiko/scoop-bucketin favor of the officialScoopInstaller/Extrasbucket (issue #222).scoops:block — Scoop is no longer published from this repo.docs/installation.mdandREADME.mdpoint users atscoop bucket add extras.docs/release-process.mddrops Scoop from the GoReleaser-driven tables.The Extras manifest (with
env_setfor theLFK_*_DIRvariables, so Scoop installs persist data across updates) is submitted separately toScoopInstaller/Extras.Do not merge until the
ScoopInstaller/ExtrasPR is merged — otherwiseinstallation.mddocuments an install path that does not work yet.Test plan
goreleaser checkpasses (config valid after removing thescoops:block)