Reorder: drag rows, Move Up/Down one slot - #24
Merged
Merged
Conversation
onMove dead on macOS when row has tap gesture. rows now .draggable + .dropDestination. move(_:to:) clamped, replace moveToTop/moveToBottom.
row tap gesture eat mouse-down, no drag start. list selection now make device active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority list move only via Move to Top/Bottom. One slot up = impossible. Fix.
What
.onMovedead: row.onTapGesture(click = make active) eat mouse-down on macOS, list never start drag. Custom.draggablealso blocked by same gesture. Fix = no custom gesture on row:List(selection:). Setter callmakeActivefor connected device. Getter = active device, so active row show system selection..onMove, with system insertion line.ScopeConfig.move(_:to:), index clamped. ReplacemoveToTop/moveToBottom.Tested
swift build,swift testpass (20). One test cover up, down, clamp at both ends, unknown UID../bundle.shok..draggable) failed in real popover, drag no start. Second try (native selection +.onMove) wait for human mouse test.