Generate uuid after initialize to support validations on id#16
Open
thetamind wants to merge 2 commits intojashmenn:masterfrom
Open
Generate uuid after initialize to support validations on id#16thetamind wants to merge 2 commits intojashmenn:masterfrom
thetamind wants to merge 2 commits intojashmenn:masterfrom
Conversation
Owner
|
cool ill take a look at this shortly. |
Owner
|
@thetamind - this looks like a good change, however we've changed the way we're testing a bit so the merge fails. Could you update the commit to match the current testing structure? Then I'll merge in the after_initialize change. |
Collaborator
|
Dude, Can you rebase your patch please, or I'll do it ) |
Collaborator
|
I tried to implement this on top of master, but my specs failed because of after_initialize - reload with fields specified is not working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate the uuid during after_initialize instead of before_create as suggested in #6. This enables validation of
idor other uuid attributes.