Rails 4 Support (Updated, w/ smdern's patches) + Ms SqlServer Support#37
Open
D1plo1d wants to merge 11 commits intojashmenn:masterfrom
Open
Rails 4 Support (Updated, w/ smdern's patches) + Ms SqlServer Support#37D1plo1d wants to merge 11 commits intojashmenn:masterfrom
D1plo1d wants to merge 11 commits intojashmenn:masterfrom
Conversation
…es a uuid column so we should not attempt to override it.
Owner
|
See #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch includes smderns patches as well as my own. The uuid column type no longer collides with the Rails 4 uuid column type when it is defined in rails 4 postgres. This is only a partial fix however since rails 4 postgres uuid columns expect SecureRandom.uuid. IMO we should consider switching to that for compatibility.
MS SqlServer support is also included.