Skip to content

Fix stale message copy actions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chel-Tbl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix stale message copy actions #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions src/app/(general)/_components/chat/messages/message-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { memo } from "react";

import { toast } from "sonner";

import { useCopyToClipboard } from "usehooks-ts";
Expand Down Expand Up @@ -28,6 +26,18 @@ interface Props {
chatId: string;
}

const getMessageText = (message: Message) => {
const textFromParts = message.parts
?.filter((part) => part.type === "text")
.map((part) => part.text)
.join("\n")
.trim();

if (textFromParts) return textFromParts;

return message.content?.trim() ?? "";
};

export const PureMessageActions: React.FC<Props> = ({
message,
isLoading,
Expand Down Expand Up @@ -74,18 +84,19 @@ export const PureMessageActions: React.FC<Props> = ({
variant="ghost"
size="icon"
onClick={async () => {
const textFromParts = message.parts
?.filter((part) => part.type === "text")
.map((part) => part.text)
.join("\n")
.trim();
const textToCopy = getMessageText(message);

if (!textFromParts) {
if (!textToCopy) {
toast.error("There's no text to copy!");
return;
}

await copyToClipboard(textFromParts);
const didCopy = await copyToClipboard(textToCopy);
if (!didCopy) {
toast.error("Failed to copy message to clipboard.");
return;
}

toast.success("Copied to clipboard!");
}}
>
Expand Down Expand Up @@ -120,11 +131,4 @@ export const PureMessageActions: React.FC<Props> = ({
);
};

export const MessageActions = memo(
PureMessageActions,
(prevProps, nextProps) => {
if (prevProps.isLoading !== nextProps.isLoading) return false;

return true;
},
);
export const MessageActions = PureMessageActions;