Repository navigation
columnFormula: accept encoded column names in the missing-column check - #228
Merged
Merged
Conversation
In the R Commander names(data) gives the encoded column names, which are valid columns, but the check only tried to encode each name and so warned "No column named ..." for every one of them (shown decoded, so for a column that does exist). Also accept names that decode to a column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JorisGoosen
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the R Commander
names(data)/colnames(data)gives the encoded column names. Those are valid columns, but the missing-column check incolumnFormula()only tried to encode each name, sowarned
No column named "3 - Average RSSI" in the dataset.for every column (the desktop decodes the message, so it names a column that does exist).The check now also accepts names that
.decodeColNamesStrict()resolves to a column. A test with a stub decoder covers both an encoded existing column (no warning) and an encoded-looking unknown name (still warns).Found while fixing the R Commander
batchAnalysis()crash in jasp-desktop (companion PR on theenterprisebranch, which bumps the submodule to this commit). On Windows that check is also what crashed the engine; the crash itself is fixed in jasp-desktop.Tests:
tests/testthat/test-columnFormula.R: 13 pass, 0 fail.🤖 Generated with Claude Code