[pull] main from hackclub:main#443
Merged
Merged
Conversation
## Summary of the problem A URL like `/api/v4/organizations/org_BG3uZB/transactions/txn_66HJYE/comments` is insanelyyyyyyy long. Let's shallow route so we can get a nice short URL like `/api/v4/comments?transaction_id=txn_66HJYE` ## Describe your changes Shallow routes comments while keeping the original nested route for backwards compatability with old clients as we update them in the near future <!-- If there are any visual changes, please attach images, videos, or gifs. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )