[pull] main from hackclub:main#446
Merged
Merged
Conversation
## Summary of the problem <!-- Why are these changes being made? What problem does it solve? Link any related issues to provide more details. --> #13786 changed our job that deletes the PII in old user sessions to not delete device info but also delete IP along with latitude and longitude. We need to clean up the existing data for this. ## Describe your changes <!-- Explain your thought process to the solution and provide a quick summary of the changes. --> Add maintenance tasks for: - Backfilling the device_info column from PaperTrail now that we are no longer clearing it - Clearing IP, latitude, and longitude data from PaperTrail, now that it is being skipped in new records. <!-- If there are any visual changes, please attach images, videos, or gifs. -->
## Summary of the problem <!-- Why are these changes being made? What problem does it solve? Link any related issues to provide more details. --> Users might visit an old link after archiving their application, which can be confusing and cause errors such as https://appsignal.com/hack-club/sites/6596247683eb67648f30f807/exceptions/incidents/2887 ## Describe your changes <!-- Explain your thought process to the solution and provide a quick summary of the changes. --> Add a before action similar to `prevent_access_after_submission` that checks if the application is archived, and redirects them to the status page where they'll have to unarchive their application before continuing. <!-- If there are any visual changes, please attach images, videos, or gifs. -->
…ct (#13785) ## Summary of the problem <!-- Why are these changes being made? What problem does it solve? Link any related issues to provide more details. --> Currently, we don't notify HCB when they have to sign if the contract is for a teen-led application. This is because HCB only signs the contract after reviewing the application, which they do on their own schedule. However, there's the case where HCB reviews an application but has to reissue the contract - even if it's for a teen-led application, the person who reissued the contract should be notified when they have to sign. ## Describe your changes <!-- Explain your thought process to the solution and provide a quick summary of the changes. --> We currently have no way in the database to determine if a contract is a reissue of another contract. This PR adds a reference to contract to the contract it is a reissue of, and uses that data to correctly determine whether or not HCB should be notified when it's their turn to sign. <!-- If there are any visual changes, please attach images, videos, or gifs. -->
Adds per to pagination closes #13682: <img width="217" height="278" alt="image" src="https://github.com/user-attachments/assets/a5b0aa88-488a-46ca-a3d8-f92ffb423c13" /> --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Gary Tou <gary@garytou.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )