[pull] main from hackclub:main#447
Merged
Merged
Conversation
## Summary of the problem - We were initially confused about whether ancestor methods contained self, so the first idea was to rename them to `self_and_ancestors` which is similar to some gems - https://github.com/amerine/acts_as_tree/blob/9895c5e91bde72f80060b9e920cc85759c99323d/lib/acts_as_tree.rb#L337-L342 - https://github.com/stefankroes/ancestry#tree-navigation uses `path` for self+ancestors and `ancestors` is ancestors only - Ultimately we kept it just `ancestor*` because that matches Ruby Module#ancestors. - The previous implementation didn't guarantee order so we modified it to guarantee order from self->parent->...->root. Some UI was depending on showing root->...->parent so we call reverse there now - in comment policy there was a place we override a variable immediately (instead of +=) which made it look buggy, just delete that line --------- Co-authored-by: Albert Chae <albertchae@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )