[pull] main from hackclub:main#448
Merged
Merged
Conversation
## Summary of the problem <!-- Why are these changes being made? What problem does it solve? Link any related issues to provide more details. --> We want to make it clear to users what to expect with application review times. Plus, it'd be good to have a single OOO callout partial that we can update whenever we have a special case (such as FIRST worlds). ## Describe your changes <!-- Explain your thought process to the solution and provide a quick summary of the changes. --> Refactored the OOO callout to be a single partial (without the FIRST worlds code since that's over), and add it to the application status page if the user is awaiting review. <img width="988" height="586" alt="image" src="https://github.com/user-attachments/assets/e03f21ad-7204-4066-ba48-75412b241d45" />
#13782) ## Summary of the problem <!-- Why are these changes being made? What problem does it solve? Link any related issues to provide more details. --> #13780 turned off the `include_all_helpers` Rails config - but this doesn't only stop our helpers from being included, it also stopped external helpers from being automatically included. In our case, the only external helper we used that was not included was `LocalTimeHelper`. Additionally, since the API v4 controller doesn't inherit from ApplicationController, it does not automatically include the main ApplicationHelper. While I don't think that v4 views currently use any helper methods of the main ApplicationHelper other than those from the helper modules it already explicitly included, I'm not 100% sure and it makes sense that they should be available. In the future, we can decide whether we want to limit the helper methods v4 has access to. ## Describe your changes <!-- Explain your thought process to the solution and provide a quick summary of the changes. --> Reapply #13780, include `LocalTimeHelper`, and include the main ApplicationHelper in v4 ApplicationHelper (the main ApplicationHelper includes the modules that v4 ApplicationHelper was explicitly including). <!-- If there are any visual changes, please attach images, videos, or gifs. -->
## Summary of the problem <!-- Why are these changes being made? What problem does it solve? Link any related issues to provide more details. --> It'd be helpful if we can link to something like hcb.hackclub.com/org/transfers where the user can select the organization they want, instead of having to provide written instructions or a GIF to show users how to get to a specific page. ## Describe your changes <!-- Explain your thought process to the solution and provide a quick summary of the changes. --> Refactors the `events_nav` method in `EventsHelper` to pull from a constant array of nav items. `SetEvent` then checks if the event slug is "org", matches the route against the available nav items, and displays the available events along with what the user will be continuing to. <img width="1495" height="1048" alt="image" src="https://github.com/user-attachments/assets/841980c0-8fd3-4051-ab45-de642466697b" /> <img width="1495" height="1048" alt="image" src="https://github.com/user-attachments/assets/0aeee92f-e081-4cfd-838e-fd857234e7f5" /> <!-- If there are any visual changes, please attach images, videos, or gifs. --> --------- Co-authored-by: Gary Tou <gary@garytou.com>
## Summary of the problem <!-- Why are these changes being made? What problem does it solve? Link any related issues to provide more details. --> #13812 removed the review_delay_callout partial being used for applications, but only replaced it with the new callout on the show page, not the review page. ## Describe your changes <!-- Explain your thought process to the solution and provide a quick summary of the changes. --> Use the correct OOO callout on the application review page. <!-- If there are any visual changes, please attach images, videos, or gifs. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )